Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 0.15 compat changes #2

Merged
merged 1 commit into from
Jun 10, 2017
Merged

Added 0.15 compat changes #2

merged 1 commit into from
Jun 10, 2017

Conversation

sdobz
Copy link

@sdobz sdobz commented Jun 9, 2017

@CodeLenny
Copy link
Owner

@sdobz Looks good at first glance, thanks for dealing with 0.15, I was avoiding dealing with the update.

Long-winded thinking:

It looks like there's also some changes to recipes according to the set difficulty, so that might need to be added to officially support 0.15.

I'd like to try running my tests on 0.15, which will require changing test/assets/download-headless-data.js.

If this isn't enough to support 0.15, I'll add a disclaimer to the README for now.


Actionable steps:

  • I'd like to merge your changes into a side branch instead of master, let's say named 0.15-compat-lua so the automated tests can run in Travis.
  • In addition, I'd like to see the result of running the tests on 0.15 by changing download-headless-data.

If you want, I can deal with changing the MR target and trying the tests on 0.15 either tonight or early tomorrow.

Again, thanks for getting this started!

@CodeLenny
Copy link
Owner

@sdobz Status update: I've added support for testing multiple Factorio versions in the test scripts, and am pushing that through now (#3). Without your changes, I am getting the by_pixel error.

Once #3 hits master, I'll see how the tests run 0.15.

@CodeLenny CodeLenny merged commit 0658084 into CodeLenny:master Jun 10, 2017
@CodeLenny
Copy link
Owner

@sdobz I've created the 0.15-compat-lua branch with your changes, and added testing 0.15 to the test configuration. Looks like everything passes! https://travis-ci.org/CodeLenny/factorio-recipe-extraction/builds/241562875 (It even improved code coverage!)

I've merged your code into master, and closed #1. I'll be rolling out a 0.1.1 release to NPM.

Thank you for contributing!

@sdobz
Copy link
Author

sdobz commented Jun 10, 2017

Excellent, thanks for your updates! I've been running into a plethora of issues getting server infrastructure onto .15, next up is https://github.com/mroote/factorio-server-manager

@CodeLenny
Copy link
Owner

@sdobz You're welcome! Good luck getting everything up to 0.15.

Are you currently using factorio-recipe-extraction? I haven't seen anything that people have done with it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants