Fix for Issue #11 #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: isDirty and reset functions where added to the model. Fixed it by moving the self-assignemnt out of the result function. So the this-Reference of the actual dirtyFlag-Object is saved in the variable self and when the result function is called later, the isDirty and reset functions are added to the dirtyFlag-Object.
|
Dear authors, Our team has discovered the same issue and I have just submitted a similar pull request. Kind regards, |
|
Thanks for the pull request @apircher. Sorry for the delay. |
This was referenced Jul 17, 2013
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: isDirty and reset functions where added to the model. Fixed it
by moving the assignment of "self" out of the result function. So the
this-Reference of the actual dirtyFlag-Object is saved in the variable
self and when the result function is called later, the isDirty and reset
functions are added to the dirtyFlag-Object and not to the viewmodel or the window.