Removed the autoToggleCanExecute option #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, Presently, if the self.canExecute has a delegate, the delegate function is called, else, the canExecute returns true. I added an "autoToggleCanExecute" that when specified and true, would toggle the boolean "canExecute" to false while the code is running. This would prevent the user from "double clicking" for example. For a reason I can't figure out, the "completeCallback" doesn't get fired, so my tests are not conclusive. Here's what I did for tests: <!DOCTYPE html> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <title></title> </head> <body> <p>ping: <span data-bind="text:message">You need JavaScript turned on.</span></p> <p>Test sync command <button data-bind="command:testCommand">Test Command</button></p> <p>Test sync command <button data-bind="command:testAsyncCommand">Test asyncCommand</button></p> <p>Enable or Disable the button: <input type="checkbox" data-bind="checked:canGo" /></p> <script src="Scripts/jquery-1.8.2.js"></script> <script src="Scripts/knockout-2.1.0.js"></script> <script src="Scripts/knockout.asyncCommand.js"></script> <script type="text/javascript"> $(function () { var ViewModel = function () { var self = this; self.message = ko.observable('pong'); self.canGo = ko.observable(false); self.testCommand = ko.command({ execute: function (callback) { self.message('sync command running'); for (i = 0; i < 1000; i++) { self.message('sync command running [' + i + ']'); now = new Date(); } self.message('sync command finished'); }, autoToggleCanExecute: true, canExecute: function (isExecuting) { return !isExecuting && self.canGo(); } }); self.testAsyncCommand = ko.asyncCommand({ execute: function (callback) { self.message('async command running'); for (i = 0; i < 1000; i++) { self.message('async command running [' + i + ']'); now = new Date(); } self.message('async command finished'); }, autoToggleCanExecute: true, canExecute: function (isExecuting) { return !isExecuting && self.canGo(); } }); } ko.applyBindings(new ViewModel()); }); </script> </body> </html>
|
Still something wrong with the encoding. And we already fixed the asyncCommand (the regular synchronous command does not have an isExecuting). Check it out in the trunk:-) |
|
great. Date: Mon, 15 Oct 2012 19:47:38 -0700 Still something wrong with the encoding. And we already fixed the asyncCommand (the regular synchronous command does not have an isExecuting). Check it out in the trunk:-) |
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the autoToggleCanExecute as requested.