[Feature] Study status changing in real time #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Study status changing in real time - npm install moment.js and react-moment
saseungmin
commented
Nov 20, 2020
src/components/main/StudyGroups.jsx
Outdated
| @@ -11,12 +11,13 @@ const StudyGroupsWrapper = styled.div` | |||
| align-content: space-between; | |||
| `; | |||
|
|
|||
| const StudyGroups = ({ groups }) => ( | |||
| const StudyGroups = ({ groups, seconds }) => ( | |||
There was a problem hiding this comment.
seconds props를 삭제해주자. 필요없다.
src/components/main/StudyGroups.jsx
Outdated
| <StudyGroupsWrapper> | ||
| {groups.map((group) => ( | ||
| <StudyGroup | ||
| key={group.id} | ||
| group={group} | ||
| seconds={seconds} |
Comment on lines
+17
to
+19
| useInterval(() => { | ||
| setRealTime(Date.now()); | ||
| }, 1000); |
There was a problem hiding this comment.
useInterval에 대한 테스트를 어떻게 작성해야할까..🤔 (coverage 실패)
|
|
||
| useEffect(() => { | ||
| function tick() { | ||
| savedCallback.current(); |
There was a problem hiding this comment.
- 여기도 coverage fail
hannut91
reviewed
Nov 20, 2020
| }, 1000); | ||
|
|
||
| const isCheckedTimeStatus = () => { | ||
| if (realTime - applyEndTime >= 0 || participants.length === personnel) { |
There was a problem hiding this comment.
시간이 초과하거나, 참여자의 수가 초과할 경우 마감이라고 표시해주는 것 같아요. 함수로 분리해주는건 어떨까요?
| setRealTime(Date.now()); | ||
| }, 1000); | ||
|
|
||
| const isCheckedTimeStatus = () => { |
There was a problem hiding this comment.
isCheckedTimeStatus는 true 혹은 false만 반환할 것 같은데 실제로는 컴포넌트를 반환하고 있네요.
There was a problem hiding this comment.
처음에 true false로 반환할려구 했던 함수였는데 컴포넌트로 반환하는걸로 변경 후 함수 이름을 변경하지 못했줬네요..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 구현 목록
interval를 사용해야 하기 때문에 커스텀useInterval를 사용한다.리액트 Hooks에서 setInterval을 사용하면 문제가 발생. (제대로 실행이 안됨.)
🤔 추가적으로 진행할 사항들
useInterval의 테스트를 작성하는 법.. coverage가 100%가 안된다. 😢아니면 이미 구현되어 있는 커스텀 훅을 npm으로 install을 할것인가.(use-interval)
코드를 보니 구현한 방식랑 거의 같음.