[Feature] Save actions for study review form #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
saseungmin
commented
Jan 30, 2021
saseungmin
commented
- redux dispatches action call firestore api
- Save review in reviews field of groups collection
- redux dispatches action call firestore api - save study review in reviews of group collection
saseungmin
commented
Jan 30, 2021
Comment on lines
+82
to
+88
| export const postUpdateStudyReview = async ({ id, review }) => { | ||
| const group = db.collection('groups').doc(id); | ||
|
|
||
| await group.set({ | ||
| reviews: fireStore.FieldValue.arrayUnion(review), | ||
| }, { merge: true }); | ||
| }; |
There was a problem hiding this comment.
firebase api 테스트에 대한 고민 좀 해보자.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.