[Feature] With firebase auth login and used localStorage #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
saseungmin
commented
Nov 29, 2020
•
saseungmin
commented
- firebase auth를 사용해서 로그인 기능 구현하기
- localStorage를 사용해서 로그인 유지하기
- 로그인 시 header 상태 변경하기 (logout)
- Implement login logic of Redux and components
- setItem and loadItem - change header status
Kihyun92
reviewed
Nov 29, 2020
Comment on lines
+21
to
+25
| if (user) { | ||
| const { email } = user; | ||
|
|
||
| dispatch(setUser(email)); | ||
| } |
Comment on lines
+53
to
+55
| useEffect(() => () => { | ||
| dispatch(clearAuth()); | ||
| }, [dispatch]); |
There was a problem hiding this comment.
이 부분이 호출되는 시점이 어떻게 될까요?
unmount 되는 시점에 auth 정보들을 clear해주는 목적이라면, react-use 라이브러리의 useUnmount를 사용해도 좋을 것 같아요~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.