Add link to study list #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- npm install style-loader, css-loader, sass-loader - Apply to index.jsx globally settings index.css
- Update test - Improve Link CSS
- create redux dispatch and get api - Add tests
- Fixed IntroduceContainer test
saseungmin
commented
Nov 18, 2020
Comment on lines
+28
to
+31
| <IntroduceContainerWrapper> | ||
| <h2>{group.title}</h2> | ||
| <p>{group.contents}</p> | ||
| </IntroduceContainerWrapper> |
There was a problem hiding this comment.
- 화면에 보여지는 부분을 더 추가하기
이후IntroduceComponent로 분리해주기.
|
saseungmin
commented
Nov 18, 2020
Comment on lines
+5
to
6
| import { MemoryRouter } from 'react-router-dom'; | ||
| import StudyGroups from './StudyGroups'; |
There was a problem hiding this comment.
- import 한 칸 띄어써야지!
또 신경 못 썼다. (자동완성의 폐해..)
Comment on lines
+7
to
8
| import { MemoryRouter } from 'react-router-dom'; | ||
| import StudyGroupsContainer from './StudyGroupsContainer'; |
Comment on lines
5
to
+6
| import styled from '@emotion/styled'; | ||
| import IntroduceContainer from '../containers/introduce/IntroduceContainer'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a linkCSS 수정하고 웹팩에 css-loader, style-loader 설정.Link추가.수정 사항 refactoring 하기Refactorings received from code reviews #6