[Improve] Login and Sign up CSS #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
saseungmin
commented
Dec 4, 2020
saseungmin
commented
- 로그인 회원가입 페이지 CSS 변경, 향상
- 버튼 hover action 추가
- Login and Register Improve CSS
saseungmin
commented
Dec 4, 2020
Comment on lines
+12
to
+27
| height: 400px; | ||
| width: 400px; | ||
| display: flex; | ||
| justify-items: center; | ||
| align-items: center; | ||
| flex-direction: column; | ||
| background: ${palette.gray[1]}; | ||
| border-radius: 1rem; | ||
| box-shadow: rgba(0, 0, 0, 0.04) 0px 4px 16px 0px; | ||
| padding: 3rem; | ||
| h2{ | ||
| margin-top: 0; | ||
| color: black; | ||
| font-weight: bold; | ||
| font-size: 2rem; | ||
| } |
There was a problem hiding this comment.
홀맨님께서 말씀해주셨던 CSS 정리가 필요하다.. 하고나서 문득 생각이 났다
fontSize
fontWeight
position
top
left
...
display
margin
padding
width
height
border
...
background
color
...
boxmodel 이외의 background, color와 같이 꾸며주는 애들은 뒤로 보내자.
가장 중요한 건 박스모델과 다른 걸 분리하는 것.
- Add test by adding link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.