Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature & Refactoring] Modal window when clicking the Apply button #79

Merged
merged 2 commits into from
Dec 7, 2020
Merged

[Feature & Refactoring] Modal window when clicking the Apply button #79

merged 2 commits into from
Dec 7, 2020

Conversation

saseungmin
Copy link
Collaborator

@saseungmin saseungmin commented Dec 7, 2020 •
edited
Loading

  • 로그인하지 않은 사용자가 신청하기 버튼 클릭시 모달창으로 띄우기로 변경
  • Introduce component 리팩토링

image

@saseungmin
[Feature] Create modal window
fedd047 
- common modal window and apply fail modal window
@saseungmin
[Feature & Refacotoring] Separate the logic for the intro page
53f83e2 
- Error modal window when a user who is not logged in clicks the Apply button
@saseungmin saseungmin merged commit 74e3c4f into CodeSoom:main Dec 7, 2020
@saseungmin saseungmin added enhancement New feature or request refactoring 리팩토링 수정사항 수정 labels Dec 7, 2020
@saseungmin saseungmin mentioned this pull request Dec 7, 2020
Closed
26 tasks
@saseungmin saseungmin deleted the change-to-apply-button-action-modal branch July 5, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request refactoring 리팩토링 수정사항 수정
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@saseungmin