-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Day one Kotlin for Hacktoberfest #358
Conversation
Here is my new pull request. Sorry about the last one without pulling from this repo first :( |
} | ||
} | ||
|
||
fizzBuzz((1..15).toList()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not wrong, a top level declaration is required.
fizzBuzz((1..15).toList()) | |
fun main() { | |
fizzBuzz((1..15).toList()) | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Kotlin script file(.kts) stand alone functions work without the associated main function. I can make the change though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case you can leave it as it is.
} | ||
} | ||
|
||
fizzBuzz((1..15).toList()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should reflect the change made in the source code file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested some minor changes. Apart from those, I don't think any other amendments are required since the logic of the program is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Please make sure you have done the following:
/Day<n>/<Language>/
/Day <n>/
all-contributors-cli