Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that repository has been really closed #21

Closed
szpak opened this issue May 29, 2016 · 0 comments
Closed

Verify that repository has been really closed #21

szpak opened this issue May 29, 2016 · 0 comments
Assignees
@szpak
Labels
enhancement
Milestone
0.7.0

Comments

@szpak
Copy link
Member

szpak commented May 29, 2016 •
edited
Loading

Nexus returns 201 Created when accepts request to close a repository:

Sending request: POST /service/local/staging/profiles/xxx/finish HTTP/1.1
Receiving response: HTTP/1.1 201 Created

It is enough for a Gradle tasks to finish successfully. Occasionally that operation can fail (e.g. signature validation when using Sonatype OSS instance). Usually it's not a big issue as closeRepository is followed by promoteRepository, however in CD pipeline with closeRepository -> pushReleaseTag -> promoteRepository steps pushing a release tag to SCM is performed while it should not.

A closeRepository task probably could wait for a close operation to finish.
@szpak szpak added this to the 0.6.0 milestone Oct 3, 2016
@szpak szpak mentioned this issue Jan 10, 2017
Closed
szpak added a commit that referenced this issue Mar 20, 2017
@szpak
[#44] Workaround issue with bypassed retry mechanism
ee0fc34 
Introduced with sharing stagingRepositoryId. Will be fixed by #21.
@szpak szpak mentioned this issue Mar 20, 2017
Closed
@szpak szpak self-assigned this Mar 24, 2017
This was referenced Mar 24, 2017
Closed
Closed
szpak added a commit that referenced this issue Mar 26, 2017
@szpak
[#21] Verify that repo transition has been finished
37087fb 
Logic implementation.
szpak added a commit that referenced this issue Mar 26, 2017
@szpak
[#21] Simplify E2E tests
ea835b2
szpak added a commit that referenced this issue Mar 26, 2017
@szpak
[#21] Stronger repository state type checking
99f35e2
szpak added a commit that referenced this issue Mar 26, 2017
@szpak
[#21] Switch close task to new mechanism
f402dab
szpak added a commit that referenced this issue Mar 26, 2017
@szpak
[#21] Switch promote task to new mechanism
e83f2b4
szpak added a commit that referenced this issue Mar 26, 2017
@szpak
[#21] Simplify mocked functional tests
2793aa5
szpak added a commit that referenced this issue Mar 26, 2017
@szpak
[#21] Enhance UnexpectedRepositoryState message
d2e3c0c
szpak added a commit that referenced this issue Mar 26, 2017
@szpak
[#21] Functional tests on transitioning
a851d6e
szpak added a commit that referenced this issue Mar 26, 2017
@szpak
[#21] Remove deprecated test method
3fa8762
szpak added a commit that referenced this issue Mar 26, 2017
@szpak
[#21] Remove deprecated test method - ctd.
d45d847
szpak added a commit that referenced this issue Mar 26, 2017
@szpak
[#21] Improve info logging
e85cc9a
@szpak szpak closed this as completed Mar 27, 2017
@szpak szpak mentioned this issue May 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szpak szpak

Labels
enhancement
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@szpak