Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postgresql collations #4696

Merged
merged 8 commits into from
Jul 1, 2024
Merged

Postgresql collations #4696

merged 8 commits into from
Jul 1, 2024

Conversation

Johnnie-kay
Copy link
Contributor

@Johnnie-kay Johnnie-kay commented May 24, 2024 •
edited by Sriparno08
Loading

Description

Created a new concept entry for Postgresql collations.

Issue Solved

Closes #4651 [Concept Entry] Postgresql collations

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@cigar-galaxy82 cigar-galaxy82 self-assigned this May 24, 2024
@cigar-galaxy82 cigar-galaxy82 added new entry New entry or entries status: under review Issue or PR is currently being reviewed postgresql PostgreSQL labels May 25, 2024
@Johnnie-kay
Copy link
Contributor Author

Hello @cigar-galaxy82, please review this PR so i can make corrections on it to close this issue and get assigned on another one.

@cigar-galaxy82
Copy link
Contributor

Sure @Johnnie-kay I will complete this by today

cigar-galaxy82
cigar-galaxy82 suggested changes Jun 1, 2024
View reviewed changes
Copy link
Contributor

@cigar-galaxy82 cigar-galaxy82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Johnnie-kay

I've suggested a few changes. Also, make sure the Metadata is written properly

content/postgresql/concepts/collation-expressions/collation-expressions.md Outdated Show resolved Hide resolved
content/postgresql/concepts/collation-expressions/collation-expressions.md Outdated Show resolved Hide resolved
content/postgresql/concepts/collation-expressions/collation-expressions.md Outdated Show resolved Hide resolved
content/postgresql/concepts/collation-expressions/collation-expressions.md Outdated Show resolved Hide resolved
content/postgresql/concepts/collation-expressions/collation-expressions.md Outdated Show resolved Hide resolved
content/postgresql/concepts/collation-expressions/collation-expressions.md Outdated Show resolved Hide resolved
content/postgresql/concepts/collation-expressions/collation-expressions.md Outdated Show resolved Hide resolved
content/postgresql/concepts/collation-expressions/collation-expressions.md Outdated Show resolved Hide resolved
content/postgresql/concepts/collation-expressions/collation-expressions.md Outdated Show resolved Hide resolved
@cigar-galaxy82
Copy link
Contributor

Hi @Johnnie-kay

Thank you for contributing to Codecademy Docs!

I've suggested a few changes please modify. Also, make sure Metadata is written correctly

Thank you!

@Johnnie-kay
Copy link
Contributor Author

Hello @cigar-galaxy82, good morninng. I have made all the marked out corrections and adjustments on this issue.

@letsbuildanything letsbuildanything self-assigned this Jun 7, 2024
@letsbuildanything letsbuildanything added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jun 7, 2024
@letsbuildanything
Copy link
Contributor

@Johnnie-kay please delete the kotlin asTimeZone entry file, as you already have a separate PR for it.

@Johnnie-kay
Copy link
Contributor Author

Hello @letsbuildanything, the asTimeZone entry file has been deleted.

@letsbuildanything letsbuildanything removed their assignment Jun 19, 2024
@letsbuildanything letsbuildanything added status: ready for next review and removed status: under review Issue or PR is currently being reviewed labels Jun 19, 2024
@Johnnie-kay
Copy link
Contributor Author

Hello @letsbuildanything please review this PR.

@Johnnie-kay
Copy link
Contributor Author

Hello @cigar-galaxy82 is there anything else to do on this issue. please review and close this PR.

@cigar-galaxy82
Copy link
Contributor

hi @Johnnie-kay review from my side is done soon someone will do the second review, and then we will merge it

@Sriparno08 Sriparno08 self-assigned this Jul 1, 2024
@Sriparno08 Sriparno08 added status: under review Issue or PR is currently being reviewed and removed status: ready for next review labels Jul 1, 2024
@Sriparno08 Sriparno08 changed the title Postgresql collation expressions Postgresql collations Jul 1, 2024
Sriparno08
Sriparno08 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @Johnnie-kay! 👍

@Sriparno08 Sriparno08 merged commit 89f3635 into Codecademy:main Jul 1, 2024
6 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 1, 2024

👋 @Johnnie-kay
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/postgresql/collations
https://github.com/Codecademy/docs/blob/main/documentation/tags.md

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed and removed status: under review Issue or PR is currently being reviewed labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sriparno08 Sriparno08 Sriparno08 approved these changes

@cigar-galaxy82 cigar-galaxy82 cigar-galaxy82 approved these changes

Assignees

@cigar-galaxy82 cigar-galaxy82

@Sriparno08 Sriparno08

Labels
new entry New entry or entries postgresql PostgreSQL status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Concept Entry] Postgresql collations
4 participants
@Johnnie-kay @cigar-galaxy82 @letsbuildanything @Sriparno08