Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin map() doc added #5339

Merged
merged 9 commits into from
Oct 15, 2024
Merged

Conversation

clamquarter
Copy link
Contributor

Description

I've added a map.md file to the kotlin/concepts/arrays subdirectory, giving a brief explanation of the map() Kotlin function.

Issue Solved

Closes #5320

Type of Change

  • Adding a new entry

Checklist

  • [ x] All writings are my own.
  • [ x] My entry follows the Codecademy Docs style guide.
  • [ x] My changes generate no new warnings.
  • [x ] I have performed a self-review of my own writing and code.
  • [x ] I have checked my entry and corrected any misspellings.
  • [x ] I have made corresponding changes to the documentation if needed.
  • [x ] I have confirmed my changes are not being pushed from my forked main branch.
  • [x ] I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • [x ] I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

@SaviDahegaonkar SaviDahegaonkar self-assigned this Sep 26, 2024
@SaviDahegaonkar SaviDahegaonkar added new entry New entry or entries status: under review Issue or PR is currently being reviewed kotlin Kotlin entries labels Sep 26, 2024
@mamtawardhani
Copy link
Collaborator

Hey @SaviDahegaonkar un-assigning you as per the discussion. Thanks!

@mamtawardhani mamtawardhani removed the status: under review Issue or PR is currently being reviewed label Sep 26, 2024
@mamtawardhani
Copy link
Collaborator

@clamquarter kindly sign the CLA at your earliest convenience so that someone from the team can start the review. 😃

@SaviDahegaonkar SaviDahegaonkar self-assigned this Sep 26, 2024
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @clamquarter ,
I had a look at your file and suggested a few changes please make them asap so I can make this PR available for a second round of review. Also please put the file in the correct path which is: content/kotlin/concepts/arrays/terms/map/map.md . And for more clarity about the changes you can get help from style-guide.

Thanks,
Savi

content/kotlin/concepts/arrays/map/map.md Outdated Show resolved Hide resolved
content/kotlin/concepts/arrays/map/map.md Outdated Show resolved Hide resolved
content/kotlin/concepts/arrays/map/map.md Outdated Show resolved Hide resolved
Comment on lines 20 to 21
## Syntax
collection.map { element -> transformation logic }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Syntax
collection.map { element -> transformation logic }
## Syntax
collection.map { element -> transformation logic }

The syntax should be always written inside the pseudo block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change appears identical to the original, could you please clarify? Are you saying I need to put this inside a pseudo block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaviDahegaonkar I realized you might not have noticed the comment because I didn't tag you.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I mean the same

content/kotlin/concepts/arrays/map/map.md Outdated Show resolved Hide resolved
clamquarter and others added 3 commits September 27, 2024 09:05
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
Copy link
Collaborator

@SaviDahegaonkar SaviDahegaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @clamquarter ,
The entry LGTM. I hereby make it available for a second round of review.

content/kotlin/concepts/arrays/terms/map/map.md Outdated Show resolved Hide resolved
content/kotlin/concepts/arrays/terms/map/map.md Outdated Show resolved Hide resolved
@mamtawardhani
Copy link
Collaborator

Please change the lables @SaviDahegaonkar

minor changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing to Codecademy Docs @clamquarter 😄

The entry is ready to be merged! 🚀

@mamtawardhani mamtawardhani removed the status: under review Issue or PR is currently being reviewed label Oct 15, 2024
prettified
@mamtawardhani mamtawardhani merged commit 738cfa4 into Codecademy:main Oct 15, 2024
6 checks passed
Copy link

👋 @clamquarter
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/kotlin/arrays/map

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] Kotlin Arrays map
4 participants