-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kotlin map() doc added #5339
Kotlin map() doc added #5339
Conversation
Hey @SaviDahegaonkar un-assigning you as per the discussion. Thanks! |
@clamquarter kindly sign the CLA at your earliest convenience so that someone from the team can start the review. 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @clamquarter ,
I had a look at your file and suggested a few changes please make them asap so I can make this PR available for a second round of review. Also please put the file in the correct path which is: content/kotlin/concepts/arrays/terms/map/map.md . And for more clarity about the changes you can get help from style-guide.
Thanks,
Savi
## Syntax | ||
collection.map { element -> transformation logic } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Syntax | |
collection.map { element -> transformation logic } | |
## Syntax | |
collection.map { element -> transformation logic } |
The syntax should be always written inside the pseudo
block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change appears identical to the original, could you please clarify? Are you saying I need to put this inside a pseudo block?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SaviDahegaonkar I realized you might not have noticed the comment because I didn't tag you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I mean the same
Co-authored-by: Savi Dahegaonkar <124272050+SaviDahegaonkar@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @clamquarter ,
The entry LGTM. I hereby make it available for a second round of review.
Please change the lables @SaviDahegaonkar |
minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing to Codecademy Docs @clamquarter 😄
The entry is ready to be merged! 🚀
prettified
👋 @clamquarter 🎉 Your contribution(s) can be seen here: https://www.codecademy.com/resources/docs/kotlin/arrays/map Please note it may take a little while for changes to become visible. |
Description
I've added a map.md file to the kotlin/concepts/arrays subdirectory, giving a brief explanation of the map() Kotlin function.
Issue Solved
Closes #5320
Type of Change
Checklist
main
branch.Issues Solved
section.