-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Term Entry: C++ Deque Push_Back() #5364
Conversation
@Cibiyanna26 please sign the CLA so that team can start reviewing this PR |
@mamtawardhani I have signed the CLA . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Cibiyanna26 thank you for contributing to Codecademy Docs! The entry is nicely written 😄
I've suggested a few modifications, could you review and make those changes at your earliest convenience? Thank you! 😃
@mamtawardhani I will look into the changes requested and will you notify you as soon as I complete. If I have any query I will reach out to you, Thanks. |
sure thing! Also regarding your hacktober fest query - we will be pushing some issues today on the docs, which will be for hacktober fest, feel free to contribute! 😄 |
Co-authored-by: Mamta Wardhani <mamta.wardhani@gmail.com>
@mamtawardhani I have made the modifications and updated the pr, check it out! |
fixed package json file
fixed yarn lock
minor changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing @Cibiyanna26 😄
The entry looks good for a second round of review! 🚀
corrected file name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @Cibiyanna26!
👋 @Cibiyanna26 🎉 Your contribution(s) can be seen here: https://www.codecademy.com/resources/docs/cpp/deque/push-back Please note it may take a little while for changes to become visible. |
Description
Issue Solved
Closes #5362
Type of Change
Checklist
main
branch.Issues Solved
section.