Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Term Entry: C++ Deque Push_Back() #5364

Merged
merged 17 commits into from
Oct 14, 2024
Merged

Conversation

Cibiyanna26
Copy link
Contributor

@Cibiyanna26 Cibiyanna26 commented Oct 2, 2024

Description

Added new entry .push_back() in the deque topic of c++.

Issue Solved

Closes #5362

Type of Change

  • Adding a new entry
  • Updating the documentation

Checklist

  • All writings are my own.
  • My entry follows the Codecademy Docs style guide.
  • My changes generate no new warnings.
  • I have performed a self-review of my own writing and code.
  • I have checked my entry and corrected any misspellings.
  • I have made corresponding changes to the documentation if needed.
  • I have confirmed my changes are not being pushed from my forked main branch.
  • I have confirmed that I'm pushing from a new branch named after the changes I'm making.
  • I have linked any issues that are relevant to this PR in the Issues Solved section.

@CLAassistant
Copy link

CLAassistant commented Oct 2, 2024

CLA assistant check
All committers have signed the CLA.

@mamtawardhani mamtawardhani self-assigned this Oct 2, 2024
@mamtawardhani
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@Cibiyanna26 please sign the CLA so that team can start reviewing this PR

@Cibiyanna26
Copy link
Contributor Author

Cibiyanna26 commented Oct 2, 2024

@mamtawardhani I have signed the CLA .

@Cibiyanna26 Cibiyanna26 mentioned this pull request Oct 2, 2024
3 tasks
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Cibiyanna26 thank you for contributing to Codecademy Docs! The entry is nicely written 😄

I've suggested a few modifications, could you review and make those changes at your earliest convenience? Thank you! 😃

content/cpp/concepts/deque/terms/push_back/push_back.md Outdated Show resolved Hide resolved
content/cpp/concepts/deque/terms/push_back/push_back.md Outdated Show resolved Hide resolved
content/cpp/concepts/deque/terms/push_back/push_back.md Outdated Show resolved Hide resolved
@Cibiyanna26
Copy link
Contributor Author

@mamtawardhani I will look into the changes requested and will you notify you as soon as I complete. If I have any query I will reach out to you, Thanks.

@mamtawardhani
Copy link
Collaborator

@mamtawardhani I will look into the changes requested and will you notify you as soon as I complete. If I have any query I will reach out to you, Thanks.

sure thing! Also regarding your hacktober fest query - we will be pushing some issues today on the docs, which will be for hacktober fest, feel free to contribute! 😄

@Cibiyanna26
Copy link
Contributor Author

@mamtawardhani I have made the modifications and updated the pr, check it out!

fixed package json file
fixed yarn lock
minor changes
Copy link
Collaborator

@mamtawardhani mamtawardhani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing @Cibiyanna26 😄

The entry looks good for a second round of review! 🚀

Copy link
Collaborator

@Sriparno08 Sriparno08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @Cibiyanna26!

@Sriparno08 Sriparno08 merged commit 8e874bd into Codecademy:main Oct 14, 2024
6 checks passed
Copy link

👋 @Cibiyanna26
You have contributed to Codecademy Docs, and we would like to know more about you and your experience.
Please take a minute to fill out this four question survey to help us better understand Docs contributions and how we can improve the experience for you and our learners.
Thank you for your help!

🎉 Your contribution(s) can be seen here:

https://www.codecademy.com/resources/docs/cpp/deque/push-back

Please note it may take a little while for changes to become visible.
If you're appearing as anonymous and want to be credited, see here.

@Sriparno08 Sriparno08 added status: review 2️⃣ completed hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest and removed status: under review Issue or PR is currently being reviewed labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ C++ entries hacktoberfest-accepted Indicates the PR was approved, merged, and pertains to Hacktoberfest new entry New entry or entries status: review 1️⃣ completed status: review 2️⃣ completed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Term Entry] C++ Deque .push_back()
4 participants