fix(RatingsBar): Conditional box shadow (hide if 0%) #2624
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Conditional box shadow (hide if 0%)
PR Checklist
Testing Instructions
Go to local gamut and yarn start.
Visit http://localhost:6006/?path=/docs/brand-labs-atoms-ratingsbar--ratings-barr
Confirm the bar still has box shadow if percent is greater than zero
Set the
minimumPercent
andpercent
to zero. Confirm you see an empty bar (without a boxshadow line to the right of the beginning edge)