Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RatingsBar): Conditional box shadow (hide if 0%) #2624

Merged

Conversation

awgraves
Copy link
Contributor

@awgraves awgraves commented Dec 9, 2022

Overview

Conditional box shadow (hide if 0%)

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: REACH-2324
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Go to local gamut and yarn start.

  2. Visit http://localhost:6006/?path=/docs/brand-labs-atoms-ratingsbar--ratings-barr

  3. Confirm the bar still has box shadow if percent is greater than zero
    expected_bar

  4. Set the minimumPercent and percent to zero. Confirm you see an empty bar (without a boxshadow line to the right of the beginning edge)
    zero_bar

@nx-cloud
Copy link

nx-cloud bot commented Dec 9, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fe26c20. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2022

CLA assistant check
All committers have signed the CLA.

@awgraves awgraves requested a review from bndiep December 9, 2022 17:09
Copy link
Contributor

@bndiep bndiep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested locally. lgtm!

@awgraves awgraves added the Ship It :shipit: Automerge this PR when possible label Dec 9, 2022
@codecademydev codecademydev merged commit 592a559 into main Dec 9, 2022
@codecademydev codecademydev deleted the agraves.REACH-2324.hide-ratings-bar-shadow-on-zero branch December 9, 2022 18:10
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants