chore!: Support React 18 [WEB-2055] #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* origin/main: (64 commits) chore(release): publish feat(Toaster): Use current color mode in `Toaster` chore(release): publish chore: update tracking package chore(release): publish fix(RatingsBar): fixes the focus on the wrapper chore(release): publish refactor(ScoreSummary): add optional description text chore(release): publish chore(Gamut + setupEnzyme): deprecate enzyme + remove tests chore(release): publish fix(ListSection): Filter out falsy children chore(release): publish fix(SelectDropdown): fix remove + remove all buttons + medium sizing change bug for `multiple` variant chore(release): publish chore: change enzyme tests to rtl in gamut-labs chore(release): publish fix(RatingsBar): Adds stroke between yellow bar and white background chore(release): publish chore(deps): bump tracking from 0.26.0 to 1.0.1 ...
* origin/main: chore(release): publish chore: update react imports and tsconfig for jsx runtime chore(release): publish feat(LayoutMenuVariant): create layout menu variant for experiment #2199
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9461f1c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
* main: (30 commits) chore(release): publish feat(FormGroupLabel, GridForm): assorted embedded user-form features chore(release): publish fix(Flyout): move background color to fix overflow chore(release): publish chore: update local node version to v16 [WEB-2205] chore(release): publish refactor(ScoreSummary): make ScoreSummary responsive chore(release): publish feat(Flyout): Added optional background prop (#2627) chore(release): publish fix: update width of page alert to match page contents chore(release): publish chore(AppHeader)!: Remove bookmarks and favorites chore(release): publish fix(RatingsBar): Conditional box shadow (hide if 0%) chore(release): publish refactor(ScoreSummary): make trackSlug and tracking optional in ScoreSummary chore(release): publish feat(Footer): rename Pro Membership link ...
jakemhiller
changed the title
jakemhiller
changed the title
|
🚀 Styleguide deploy preview ready! |
📬Published Alpha Packages:@codecademy/gamut-icons@7.9.8-alpha.9461f1.0 |
aresnik11
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for React 18 WITHOUT actually using React 18 locally for tests or storybook. We will be updating those to React 18 as a follow up. This should allow clients to update to React 18.
Add support for React 18
This is a breaking change for
gamut-stylesbecause we have removedreact-helmetfrom theAssetProvidercomponent. You'll need to wrapAssetProviderin an instance ofreact-helmetin your app.PR Checklist
Testing Instructions
Don't make me tap the sign.
PR Links and Envs