Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Icons): Rename WhatsAppIcon to WhatsAppFilledIcon #2827

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix(Icons): Rename WhatsAppIcon to WhatsAppFilledIcon #2827

merged 1 commit into from
Jan 11, 2024

Conversation

bndiep
Copy link
Contributor

@bndiep bndiep commented Jan 11, 2024

Overview

renames WhatsAppIcon to WhatsAppFilledIcon

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@bndiep bndiep requested a review from a team as a code owner January 11, 2024 18:31
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@55.10.11-alpha.4e2eb7.0
@codecademy/gamut-icons@9.15.1-alpha.4e2eb7.0
@codecademy/gamut-kit@0.6.375-alpha.4e2eb7.0
@codecademy/styleguide@66.9.1-alpha.4e2eb7.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://65a035a6511fda21ba860d34--gamut-preview.netlify.app

Deploy Logs

jakemhiller
jakemhiller approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bndiep bndiep added the Ship It :shipit: Automerge this PR when possible label Jan 11, 2024
@codecademydev codecademydev merged commit 617c072 into main Jan 11, 2024
20 of 22 checks passed
@codecademydev codecademydev deleted the bd.update-whats-app-icon-name branch January 11, 2024 20:12
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

@dreamwasp dreamwasp Awaiting requested review from dreamwasp dreamwasp is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bndiep @codecademydev @jakemhiller