Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Icons): add MicrophoneIcon,RecordingIcon and ListeningIcon #2829

Merged
merged 4 commits into from
Feb 7, 2024
Merged

feat(Icons): add MicrophoneIcon,RecordingIcon and ListeningIcon #2829

merged 4 commits into from
Feb 7, 2024

Conversation

JahazielGuzman
Copy link
Contributor

@JahazielGuzman JahazielGuzman commented Feb 2, 2024 •
edited
Loading

Overview

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: LEGO-3650
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@JahazielGuzman JahazielGuzman changed the title add mic and recording icons feat(Icons): add MicrophoneIcon and RecordingIcon Feb 2, 2024
@JahazielGuzman JahazielGuzman changed the title feat(Icons): add MicrophoneIcon and RecordingIcon feat(Icons): add MicrophoneIcon,RecordingIcon and ListeningIcon Feb 6, 2024
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@55.12.1-alpha.00049c.0
@codecademy/gamut-icons@9.15.2-alpha.00049c.0
@codecademy/gamut-kit@0.6.378-alpha.00049c.0
@codecademy/styleguide@66.10.1-alpha.00049c.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://65c3b7dc95121455f5a5d651--gamut-preview.netlify.app

Deploy Logs

@JahazielGuzman JahazielGuzman marked this pull request as ready for review February 7, 2024 19:07
@JahazielGuzman JahazielGuzman requested a review from a team as a code owner February 7, 2024 19:07
dreamwasp
dreamwasp approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@JahazielGuzman JahazielGuzman added the Ship It :shipit: Automerge this PR when possible label Feb 7, 2024
@codecademydev codecademydev merged commit 1957899 into main Feb 7, 2024
22 of 23 checks passed
@codecademydev codecademydev deleted the jz-mic-recording-icons branch February 7, 2024 20:00
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JahazielGuzman @codecademydev @dreamwasp