Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popover): add position to popover stories #2852

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix(popover): add position to popover stories #2852

merged 1 commit into from
Mar 21, 2024

Conversation

sooinc
Copy link
Contributor

@sooinc sooinc commented Mar 21, 2024 •
edited
Loading

Overview

  • updating popover stories to include position prop

PR Checklist

  • Related to designs:
  • Related to JIRA ticket: [ABC-123]
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Screenshot 2024-03-21 at 2 09 36 PM Screenshot 2024-03-21 at 2 09 24 PM
  1. check out the new position section in popover stories: https://65fc7a5c38fbe95a637a67ea--gamut-preview.netlify.app/?path=/docs/molecules-popover--popover#position

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Monolith Monolith PR Monolith Env
Portal Portal Link Portal Env
Another Repo Another Link Another Env

@sooinc sooinc requested a review from a team as a code owner March 21, 2024 18:11
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/styleguide@66.14.3-alpha.6fda20.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://65fc7a5c38fbe95a637a67ea--gamut-preview.netlify.app

Deploy Logs

@sooinc sooinc requested a review from dreamwasp March 21, 2024 18:30
dreamwasp
dreamwasp approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@dreamwasp dreamwasp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have rarely felt such joy 😆 thanks for picking this up

@sooinc sooinc added the Ship It :shipit: Automerge this PR when possible label Mar 21, 2024
@codecademydev codecademydev merged commit dd872c5 into main Mar 21, 2024
22 of 25 checks passed
@codecademydev codecademydev deleted the sc-update-popover-stories branch March 21, 2024 18:38
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwasp dreamwasp dreamwasp approved these changes

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

@aresnik11 aresnik11 Awaiting requested review from aresnik11 aresnik11 is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sooinc @codecademydev @dreamwasp