Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Icons): add ProfessionalCertificateIcon #2885

Merged
merged 3 commits into from
Jun 12, 2024
Merged

feat(Icons): add ProfessionalCertificateIcon #2885

merged 3 commits into from
Jun 12, 2024

Conversation

bndiep
Copy link
Contributor

@bndiep bndiep commented Jun 7, 2024 •
edited by jira bot
Loading

Overview

Add ProfessionalCertificateIcon under LE section to be used on container landing pages

PR Checklist

  • Related to designs: Figma node
  • Related to JIRA ticket: DOT-309
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

Don't make me tap the sign.

PR Links and Envs

Repository PR Link PR Env
Portal Portal Link Portal Env

@bndiep bndiep changed the title featt(Icons): add ProfessionalCertificateIcon feat(Icons): add ProfessionalCertificateIcon Jun 7, 2024
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/gamut@55.22.2-alpha.82c873.0
@codecademy/gamut-icons@9.27.1-alpha.82c873.0
@codecademy/gamut-kit@0.6.414-alpha.82c873.0
@codecademy/styleguide@66.24.1-alpha.82c873.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://666741ecce0da22273fe589f--gamut-preview.netlify.app

Deploy Logs

@bndiep bndiep marked this pull request as ready for review June 12, 2024 14:58
@bndiep bndiep requested a review from a team as a code owner June 12, 2024 14:58
@bndiep bndiep requested review from jakemhiller, BandanaKM and a team June 12, 2024 14:58
LinKCoding
LinKCoding approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@LinKCoding LinKCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

checked on both light and dark mode and it looks good :)

@bndiep bndiep added the Ship It :shipit: Automerge this PR when possible label Jun 12, 2024
@codecademydev codecademydev merged commit b58018f into main Jun 12, 2024
29 of 30 checks passed
@codecademydev codecademydev deleted the bd.add-professional-certificate-icon branch June 12, 2024 17:42
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinKCoding LinKCoding LinKCoding approved these changes

@jakemhiller jakemhiller Awaiting requested review from jakemhiller jakemhiller is a code owner automatically assigned from Codecademy/gamut

@BandanaKM BandanaKM Awaiting requested review from BandanaKM BandanaKM is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bndiep @codecademydev @LinKCoding