Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(misc): updating component statuses in SB #2899

Merged
merged 3 commits into from
Jul 1, 2024
Merged

docs(misc): updating component statuses in SB #2899

merged 3 commits into from
Jul 1, 2024

Conversation

LinKCoding
Copy link
Contributor

@LinKCoding LinKCoding commented Jun 28, 2024 •
edited
Loading

Overview

PR Checklist

  • Related to JIRA ticket: GM-754
  • I have run this code to verify it works
  • This PR includes unit tests for the code change
  • This PR includes testing instructions tests for the code change
  • The alpha package of this PR is passing end-to-end tests in all relevant Codecademy repositories

Testing Instructions

  1. Look over the JIRA ticket
  2. Go to the respective pages
  3. Check that the statuses match
  4. ...
  5. Profit!

@LinKCoding LinKCoding requested a review from a team as a code owner June 28, 2024 20:14
@LinKCoding LinKCoding marked this pull request as draft June 28, 2024 20:14
@codecademydev
Copy link
Collaborator

📬Published Alpha Packages:

@codecademy/styleguide@66.29.1-alpha.aed383.0

@codecademydev
Copy link
Collaborator

🚀 Styleguide deploy preview ready!

https://667f1d40c6a6497c2b57cbb9--gamut-preview.netlify.app

Deploy Logs

@LinKCoding LinKCoding marked this pull request as ready for review June 28, 2024 20:31
@LinKCoding
Copy link
Contributor Author

Personally checked over twice as noted in JIRA ticket -- feel free to double check work :) thanks!

jakemhiller
jakemhiller approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@jakemhiller jakemhiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

aresnik11
aresnik11 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@aresnik11 aresnik11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only thing is I see Anchor ⇒ updating on the list but that's not updated here

@LinKCoding
Copy link
Contributor Author

LGTM! Only thing is I see Anchor ⇒ updating on the list but that's not updated here

Thanks Amy, I updated Anchor recently (adding in icons) and that seemed to be the only ticket associated with Anchor -- but I'll double check with Cass before merging :)

@LinKCoding
Copy link
Contributor Author

Checked with Cass and it's good to go!

@LinKCoding LinKCoding added the Ship It :shipit: Automerge this PR when possible label Jul 1, 2024
@codecademydev codecademydev merged commit e99a66f into main Jul 1, 2024
19 of 21 checks passed
@codecademydev codecademydev removed the Ship It :shipit: Automerge this PR when possible label Jul 1, 2024
@codecademydev codecademydev deleted the kl-gm-754 branch July 1, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakemhiller jakemhiller jakemhiller approved these changes

@aresnik11 aresnik11 aresnik11 approved these changes

@timjenkins timjenkins Awaiting requested review from timjenkins timjenkins is a code owner automatically assigned from Codecademy/gamut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LinKCoding @codecademydev @jakemhiller @aresnik11