Replace return with yield when docComments returns Generator #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, looks like the best option for now |
DavertMik
added a commit
that referenced
this pull request
Oct 30, 2015
Replace return with yield when docComments returns Generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After implementing AspectMock to make some nicer tests in part of my suite, other part of my suite started to fail due to using Generators. After searching through the issues (#50) was poking around a bit in the code to find a solution. This does work for me, but you need to make sure the DocComment is properly formatted.
There might be a better solution, by really inspecting the method signature, but I couldn't find out so quickly how that should be done. If anyone has a hint, feel free to help me on the right track. Else this could be an option to merge.