New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent REST helper from mutating default headers #789

Merged
merged 1 commit into from Nov 21, 2017

Conversation

Projects
None yet
2 participants
@alexashley
Contributor

alexashley commented Nov 21, 2017

Closes #784. I linked this locally and ran it against my reproduction repo and everything looked good. The root cause was the assignment in the constructor causes the default headers to be mutated with every haveRequestHeaders.

The downside is that any tests that relied on this behavior are now broken (possibly including any Before hooks, but I haven't tested this).

@DavertMik

This comment has been minimized.

Show comment
Hide comment
@DavertMik

DavertMik Nov 21, 2017

Member

Looks like tests are passing so the PR is ok to me!
Thanks!

Member

DavertMik commented Nov 21, 2017

Looks like tests are passing so the PR is ok to me!
Thanks!

@DavertMik DavertMik merged commit b33928d into Codeception:master Nov 21, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
semaphoreci The build passed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment