Dot notation for params replacement. Fixes #3339 #3372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove duplicated trait usage
Fixed Logger extension
…r-encodings #3191 change ucfirst for multibyte character encodings
* gherkin languages support * Fix gherking i18n file path
UTF-8 improvements
fix search input field by label
Conflicts: src/Codeception/Scenario.php src/Codeception/Subscriber/Console.php
* Fix for issue #3112 Group events fire twice. * Updated Dummy Test count. * Updated Dummy Test count.
Fix return types in the docblocks of the `findRecord` methods of the Laravel5 and Lumen modules.
Added Laravel5 and Lumen module changes to CHANGELOG
REST stop/startFollowingRedirects methods to be part of JSON and XML parts
…cked/dontSeeCheckboxIsChecked methods
Fixed creating snapshot files on failure. Closes #3207
Update Lumen amLoggedAs to be compatible with 5.2
added project maintenance improvements
fix typo in JsonType documentation
Add callArtisan method to Laravel5 module
Laravel5 add run_database_migrations configuration option
* Update Cest.php Don't need to manage group here, it will be done later * Update GroupManager.php Manage group for DataProvider here and take the group of the first example because you can't manage different group between different example for the same test (Group by annotation and Group by file is working) * Update SuiteManager.php Update GroupDetails of DataProvider after the groups retrieved * Update GroupManager.php * Update SuiteManager.php * Update GroupManager.php * Update GroupManager.php * Update SuiteManager.php * Update GroupManager.php * Update GroupManager.php * Update GroupManager.php
Improved Yii2 module: * init part added to work with unit/acceptance tests * added entryScript and entryUrl config values * added amOnRoute method * added amloggedAs method * added fixtures support * added grabComponent method * added mocked mailer component * grabLastSentEmail should return actual last email * created logger in debug mode, * mocked assetManager
* fixed time calculation. Fixes #3331 * Added RequiresPackage interface and validation to check external package dependencies for modules
| continue; | ||
| $value = $this->vars; | ||
| foreach (explode('.', $placeholder) as $segment) { | ||
| if (is_array($value) && array_key_exists($segment, $value)) { |
There was a problem hiding this comment.
Since it's used a lot it could be adjusted as is_array($value) && isset($value[$segment]) && array_key_exists($segment, $value) to get extra performance. Needs to be measured though...
There was a problem hiding this comment.
I guess in this case you may not need is_array check as well
|
IDK what's with tests |
|
@neoascetic your branch is out of date, Update your branch this way: |
|
I thought this is a new feature and that's why I've branched from the master |
|
Closed in favor to #3373 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.