Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codebase to PHP 7.4 #47

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Update codebase to PHP 7.4 #47

merged 3 commits into from
Dec 2, 2021

Conversation

TavoNiievez
Copy link
Member

No description provided.

@TavoNiievez TavoNiievez marked this pull request as draft October 17, 2021 23:10
@TavoNiievez
Copy link
Member Author

TavoNiievez commented Oct 17, 2021

@olexp

While doing this PR I could see that the same code that was merged via #45 on July 26 now fails. This is the result of the test:

There was 1 failure:

---------
1) Doctrine2Test: Have fake repository
 Test  tests/unit/Codeception/Module/Doctrine2Test.php:testHaveFakeRepository
Failed asserting that actual size 0 matches expected size 2.
#1  /home/runner/work/module-doctrine2/module-doctrine2/tests/unit/Codeception/Module/Doctrine2Test.php:578

Even without making any changes to the code, the test fails.

Could you please check what's going on?

@olexp
Copy link
Contributor

olexp commented Oct 18, 2021

This commit breaks it: doctrine/orm@84ad007
I will provide fix later today.

@TavoNiievez TavoNiievez merged commit afcf8f4 into master Dec 2, 2021
@TavoNiievez TavoNiievez deleted the php74 branch December 2, 2021 00:05
@TavoNiievez TavoNiievez added this to the 2.0.0 milestone Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants