Skip to content

Update seeEmailIsSent #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2020
Merged

Update seeEmailIsSent #78

merged 1 commit into from
Dec 15, 2020

Conversation

TavoNiievez
Copy link
Member

Now that $expectedCount is typed ?int, it is no longer necessary:

	if (!is_int($expectedCount) && !is_null($expectedCount)) { }

and if grabCollector is used, it is not necessary:

	if (($profile = $this->getProfile()) === null) { }
	if (!$profile->hasCollector($mailer)) { }

since that method includes these validations.

I remove an unused function declaration, and fix a conditional for the error message verb.

@TavoNiievez TavoNiievez modified the milestones: 1.6.0, 9.9.9 Dec 13, 2020
@TavoNiievez TavoNiievez merged commit cab80ca into Codeception:master Dec 15, 2020
@TavoNiievez TavoNiievez deleted the seeEmailIsSent branch December 15, 2020 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@TavoNiievez