Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct type declaration for amOnPage method #86

Merged
merged 2 commits into from
May 16, 2023
Merged

Use correct type declaration for amOnPage method #86

merged 2 commits into from
May 16, 2023

Conversation

erickskrauch
Copy link
Contributor

This will help me fix my PHPStan integration 🤞

@SamMousa
Copy link
Collaborator

I think we added amOnRoute for that, can you check?

@erickskrauch erickskrauch requested a review from samdark May 16, 2023 13:37
@SamMousa
Copy link
Collaborator

Ah apologies, I shouldn't review PRs on mobile.
LGTM.

@SamMousa SamMousa merged commit 07db4a4 into Codeception:master May 16, 2023
@samdark samdark mentioned this pull request Jun 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark Awaiting requested review from samdark

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erickskrauch @SamMousa @samdark