Max execution time #120
Merged
Max execution time #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccsuperstar
force-pushed
the
maxExecutionTime
branch
from
5e50592
to
69131eb
Compare
ccsuperstar
force-pushed
the
maxExecutionTime
branch
5 times, most recently
from
c6371bf
to
154a66a
Compare
ccsuperstar
force-pushed
the
maxExecutionTime
branch
8 times, most recently
from
945b319
to
dde8c12
Compare
ccsuperstar
force-pushed
the
maxExecutionTime
branch
2 times, most recently
from
7b56aa4
to
107e9e7
Compare
Arhell
reviewed
Nov 18, 2022
|
@ccsuperstar Thank you for your contribution. Please do not forget to write a test for your changes. |
yes I will do it, then I guess I have to do tests for codeception 5 and for the previous versions |
ccsuperstar
force-pushed
the
maxExecutionTime
branch
5 times, most recently
from
2dccaaa
to
bd82ac3
Compare
vansari
reviewed
Nov 22, 2022
ccsuperstar
requested review from
vansari and
Arhell
and removed request for
Arhell and
vansari
vansari
requested changes
Dec 17, 2022
…me of all html reports for report.html
ccsuperstar
force-pushed
the
maxExecutionTime
branch
from
bd82ac3
to
d91d2bf
Compare
vansari
approved these changes
Jan 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #119
The html reports with Codeception 4 have an execution time format of the form 198.165s
The html reports with Codeception 5 have an execution time format of the form 22:45.165
The regex matches both versions
Added maxSuiteTime support for the final xml report (the execution time of a suite is the longest run time among all parallel runs)
max($this->suiteDuration[$suiteName])Added maxTime support for the final html report (the total execution time is the longest run time among all parallel runs)
$this->executionTime[] = (string)$matches['timesum'];$executionTime = max($this->executionTime);I am looking for feedbacks, I think everything can be improved!