Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create data set on overall vaccination rates #39

Merged
merged 3 commits into from
Oct 17, 2018

Conversation

rafagarciac
Copy link
Contributor

Add new overall_vaccination_twelve_to_twenty_three_months.csv file.

Add new overall_vaccination_twelve_to_twenty_three_months.csv file.
Copy link
Member

@cliftonmcintosh cliftonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rafagarciac

Thank you for submitting the PR. Can you please take a look at the following issues?

  1. It looks like the only value here is "BASIC". Why are there no rows for "NONE" or "ALL"? Are 100% of the children in each province in the "All basic vaccinations" column?
  2. Small thing, but there should be a space between the word Province and the number, so, for example, "Province 1" instead of "Province1"

@cliftonmcintosh
Copy link
Member

@rafagarciac

do you plan on updating your PR or should we open up the issue for someone else to complete?

@cliftonmcintosh
Copy link
Member

Closing because the data are incorrect and @rafagarciac has not responded to inquires about whether they will be corrected.

@cliftonmcintosh
Copy link
Member

@rafagarciac

My apologies. I realize now you may have been waiting for guidance about the percentages. I have updated the description in #37

If you would like to update this PR based on that guidance, please let me know.

@cliftonmcintosh
Copy link
Member

Re-opening for @rafagarciac to address change request

@cliftonmcintosh
Copy link
Member

cliftonmcintosh commented Oct 16, 2018

@rafagarciac

Thank you for the update.

I have done some spot-checking. "BASIC" and "ALL" seem to be reversed for Province 1 but not for Province 2. I have not gone through all of the provinces. Can you please double-check?

@rafagarciac
Copy link
Contributor Author

Ok, yes I had a mistake because it was the first one. However I reviewed all Provinces and it's seems that all operations are correct ! ✔️ b287a07

@cliftonmcintosh cliftonmcintosh merged commit 8ade673 into CodeforNepal:master Oct 17, 2018
@cliftonmcintosh
Copy link
Member

@rafagarciac

Thank you for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants