-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create data set on overall vaccination rates #39
Conversation
Add new overall_vaccination_twelve_to_twenty_three_months.csv file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting the PR. Can you please take a look at the following issues?
- It looks like the only value here is "BASIC". Why are there no rows for "NONE" or "ALL"? Are 100% of the children in each province in the "All basic vaccinations" column?
- Small thing, but there should be a space between the word Province and the number, so, for example, "Province 1" instead of "Province1"
do you plan on updating your PR or should we open up the issue for someone else to complete? |
Closing because the data are incorrect and @rafagarciac has not responded to inquires about whether they will be corrected. |
My apologies. I realize now you may have been waiting for guidance about the percentages. I have updated the description in #37 If you would like to update this PR based on that guidance, please let me know. |
Re-opening for @rafagarciac to address change request |
Thank you for the update. I have done some spot-checking. "BASIC" and "ALL" seem to be reversed for Province 1 but not for Province 2. I have not gone through all of the provinces. Can you please double-check? |
Ok, yes I had a mistake because it was the first one. However I reviewed all Provinces and it's seems that all operations are correct ! ✔️ b287a07 |
Thank you for your contribution. |
Add new overall_vaccination_twelve_to_twenty_three_months.csv file.