Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite scroll loads posts of incorrect language #2696

Closed
vytisbulkevicius opened this issue Apr 1, 2021 · 1 comment
Closed

Infinite scroll loads posts of incorrect language #2696

vytisbulkevicius opened this issue Apr 1, 2021 · 1 comment
Assignees
@cristian-ungureanu
Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.

Comments

@vytisbulkevicius
Copy link
Contributor

Description:

Neve theme allows enabling infinite scroll -
image

It works fine if the theme has only 1 language but when there are multiple languages infinite scroll loads post of another language.
The client reported it using the WPML plugin and I also made the test using the WPML plugin.

Default Language - English
2nd Language - Lithuanian

I have 6 posts that are created for both languages:
image

WP Instance is set up to show 5 posts and then show more on scroll. (Issue does not have when pagination is enabled instead of the infinite scroll).

All posts translated to LT languages have LT letters at the end of the post name.

Screencast with English (default) language - https://vertis.d.pr/Z6RgEL (works correctly)
Screencast with Lithuanian (2nd) language - https://vertis.d.pr/JESo9s (incorrect - no LT letters at the loaded post).

A screencast that shows how it works (correctly) with pagination -https://vertis.d.pr/JVcJEr

How to reproduce:

  1. Install WPML plugin and create some posts with default and at least one another language. (translate those posts)
  2. Enable infinite scroll in Neve settings.
  3. Try to load those posts with default language and then with 2nd language to see if posts of correct language are loaded.

Expected behaviour:

Posts from active language should be loaded.

Current behaviour:

When the 2nd language is active - posts are loaded from the default language on infinite scroll.

Reference:

Screenshots/screencasts provided above.
Behavior can be tested here for 7 days -

Admin area URL: https://invincibleview.tastewp.com/wp-admin
Username: bvytis
Password: 1xZzEsg9Uz8

Technical info

  • WordPress version: 5.7
  • Theme version: 2.10.4

Ticket - https://secure.helpscout.net/conversation/1468950105/273011
@vytisbulkevicius vytisbulkevicius added the bug This label could be used to identify issues that are caused by a defect in the product. label Apr 1, 2021
cristian-ungureanu pushed a commit that referenced this issue Apr 26, 2021
fix: infinite scroll and WPML compatibility [#2696]
04de5a3
cristian-ungureanu pushed a commit that referenced this issue Apr 26, 2021
fix: infinite scroll and polylang compatibility [#2696]
fce92da
cristian-ungureanu pushed a commit that referenced this issue Apr 26, 2021
chore: check if wpml or polylang [#2696]
bb35055
@cristian-ungureanu cristian-ungureanu mentioned this issue Apr 26, 2021
Merged
cristian-ungureanu pushed a commit that referenced this issue Apr 26, 2021
chore: regenerate pot [#2696]
bf3c33a
@selul selul mentioned this issue Apr 27, 2021
Merged
abaicus added a commit that referenced this issue Apr 28, 2021
@abaicus
release: new version
018c07b 
- [Fix] Dropdowns (input select) in specific widgets do not respect global form styles  - #2581
- [Fix] Wrong text color inheritance in group blocks with color settings - #2540
- [Fix] Cart icon opening behavior when positioned on the left side of header - #2468
- [Fix] Improve accessibility for external links in the Neve page and customizer
- [Fix] Color Picker Modal remains open even after switching Color Palettes - #2628
- [Fix] Increase Templates Cloud visibility on Neve options page
- [Fix] Infinite scroll loads posts of incorrect language - #2696
- [Feat] Add global color as presets in beaver builder - #2328.
- [Feat] Ignore lazyload on above the fold images 
- [Feat] implement next page links for infinite scroll
- [Feat] Adds compatibility for meta association on template import/export for Neve Cloud
pirate-bot added a commit that referenced this issue Apr 28, 2021
@pirate-bot
chore(release): 2.11.2
c3f5670 
##### [Version 2.11.2](v2.11.1...v2.11.2) (2021-04-28)

- [Fix] Dropdowns (input select) in specific widgets do not respect global form styles  - #2581
- [Fix] Wrong text color inheritance in group blocks with color settings - #2540
- [Fix] Cart icon opening behavior when positioned on the left side of header - #2468
- [Fix] Improve accessibility for external links in the Neve page and customizer
- [Fix] Color Picker Modal remains open even after switching Color Palettes - #2628
- [Fix] Increase Templates Cloud visibility on Neve options page
- [Fix] Infinite scroll loads posts of incorrect language - #2696
- [Feat] Add global color as presets in beaver builder - #2328.
- [Feat] Ignore lazyload on above the fold images
- [Feat] implement next page links for infinite scroll
- [Feat] Adds compatibility for meta association on template import/export for Neve Cloud
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Apr 28, 2021
@selul selul closed this as completed Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cristian-ungureanu cristian-ungureanu

Labels
bug This label could be used to identify issues that are caused by a defect in the product. released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@selul @cristian-ungureanu @vytisbulkevicius @pirate-bot