fix: page reload when failing to close the popup #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
preda-bogdan
approved these changes
Feb 20, 2024
|
🎉 This PR is included in version 9.0.25 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The closing of the auth popup is affected by this https://developer.mozilla.org/en-US/docs/Web/API/Window/open#same-origin_policy since the authentication is done on a different origin.
The data communication still happens, but accessing the opener raised a DOM exception.
Because of this exception, the page refresh does not happen. Thus, the user does not see the account added, and it gets confusing because the message from the authorization popup tells him that a redirection needs to happen; otherwise, he needs to contact support.
Solution
By using a
tryblock, even if the code fails to close the popup, the page reload will happen, and the user will see their account added.Screenshots
2024-02-19_17-23-09.mp4
Testing