Docker compose #56

sdecandelario · 2018-10-08T19:40:22Z

I added a docker-compose, taking as example the old one and making some improvements. Is opened to discussion and to improve the ecosystem.

…he constructor in video like creation

jorge07 · 2018-10-08T22:18:10Z

global/config/parameters.yml

+# This file is auto-generated during the composer install
+parameters:
+    locale: en
+    secret: f89f0fadda52bf9275459ef5ae135712e29e95a0


It should be an env var.

jorge07 · 2018-10-08T22:18:43Z

etc/infrastructure/nginx/site.conf

+    server_name api.codelytv.dev;
+    root /app/applications/api/web;
+
+    error_log  /var/log/nginx/error.log;


Why not stdout and stderr?

jorge07 · 2018-10-08T22:19:42Z

docker-compose.yml

+        build:
+            context: etc/infrastructure/php
+        ports:
+            - "2244:22"


No ssh in Dockerfile

jorge07 · 2018-10-08T22:20:24Z

docker-compose.yml

+            - PHP_IDE_CONFIG=serverName=CodelyCQRSCourse
+        depends_on:
+            - mysql
+        working_dir: "/app"


Why not define this in the Dockerfile instead?

jorge07 · 2018-10-08T22:21:02Z

etc/infrastructure/php/Dockerfile

+RUN apk --update upgrade \
+    && apk add autoconf automake make gcc g++
+
+RUN apk add rabbitmq-c rabbitmq-c-dev \


A single run instruction is much recommended here

jorge07 · 2018-10-08T22:21:53Z

etc/infrastructure/php/Dockerfile

+    && pecl install amqp apcu\
+    && docker-php-ext-enable amqp apcu
+
+CMD ["sh", "-c", "composer install && php-fpm"]


Why composer install is container start? The provisioning should be in an early stage IMHO

But I think for development is nice when you start the environment that install dependencies, thinking about someone new to the project. Or it's better to put in the Dockerfile instead?

I would also go for the approach suggested by @jorge07. The reason why is because provisioning (running the composer install) in an early stage of our Dockerfile would allow us to perform some optimizations 😬

One of these optimizations would be applying the builder pattern or Multistage builds. You can read more information about them in the "Docker: De 0 a deploy" CodelyTV Pro course by @fiunchinho (here you have the course repository with some examples), and a blog post about this technic and its benefits.

However, we've tried to apply this strategy and we've miserably failed (🤣). The reason why we haven't been able to do so is because the PHP Dockerfile is in a subdirectory and it can't copy the composer.json file (it is inside the parent folder).

I've opened an isolated issue in order to deal with this (comments and suggestions welcomed!). This way we can go ahead merging all the improvements contained in this PR 🙂

…hp service

…o configure php extensions

xserrat · 2018-10-14T17:37:25Z

Hi @sdecandelario ,

I've found a way to import an initial database using the official mysql image you use in the docker-compose.yml file. You only need to create a Dockerfile that uses the same image and then, copy the content of the databases folder to /docker-entrypoint-initdb.d.

etc/infrastructure/mysql/Dockerfile:

FROM mysql:5.7.23

COPY etc/infrastructure/mysql/databases /docker-entrypoint-initdb.d

here I've moved the video.sql file under etc/infrastructure/mysql/databases

And docker-compose.yml:

 mysql:
        build:
            dockerfile: etc/infrastructure/mysql/Dockerfile
            context: .
        container_name: cqrs_codely_tv_mysql
        ports:
            - "3306:3306"
        env_file:
            - .env

I hope it helps :)

See documentation https://hub.docker.com/_/mysql/ section Initializing a fresh instance:

Initializing a fresh instance:
When a container is started for the first time, a new database with the specified name will be created and initialized with the provided configuration variables. Furthermore, it will execute files with extensions .sh, .sql and .sql.gz that are found in /docker-entrypoint-initdb.d. Files will be executed in alphabetical order. You can easily populate your mysql services by mounting a SQL dump into that directory and provide custom images with contributed data. SQL files will be imported by default to the database specified by the MYSQL_DATABASE variable.

sdecandelario · 2018-10-18T10:18:38Z

Hello @xserrat, that's a nice point. But maybe it's more interesting mount a volume mapping a directory of the project with the mysql docker image? In this way you don't need to change the Dockerfile and everyone can use it without effort :)

xserrat · 2018-10-19T18:52:05Z

@sdecandelario, I totally agree with you! Mapping the /docker-entrypoint-initdb.d directory in the docker-compose.yml it's much more simple :)

* Docker Compose: * Do not specify patch versions of the used images. Example: from `nginx:1.15.5-alpine` to `nginx:1.15-alpine`. Why: allow to upgrade automatically to a nugfix versions (we're using this repo as a example and we don't need to maintain a strict relation with a production environment) * Change the ports mapping to a non standard ones in the host machine. Example: Nginx from port `80` to port `8030`. Why: Avoid collisions with other containers or services exposed in these ports in the host machine. We have set the `XX30` as the ending port for this project (don't ask why 🤷‍♂️) * Renamed the container names. Example: from `cqrs_codely_tv_nginx` to `codelytv-cqrs_ddd_php_example-nginx`. Why: Follow a standard naming in order to avoid collisions and make it easier to find the needed container. Convention: `%vendor%-%repository_or_project%-%docker_service%` * Changed the indentation in the `docker-compose.yml` from 4 to 2 spaces. Why: Follow the same convention as in the official Docker Compose website and community examples * Modified the volume mapping `$PWD` by the shorter version of the current directory: `.` * Nginx: * Renamed `/etc/infrastructure/nginx/site.conf` to `default.conf`. Why: Maintain the same standard name used by Nginx * PHP: * Updated the `PHP_IDE_CONFIG=serverName` value to `CodelyTvCqrsDddPhpExample` in order to maintain the same naming conventions suggested avobe * Dockerfile: * Removed the `maintainer` label since we're not publishing this image in any Docker Registry and it could be confusing for other collaborators to expect updates from an ocassional contributor to the repository * Added pdo and pdo_mysql extensions installation because we need them to run production code * Added xdebug installation because we need them to debug while developing * Unified all the commands to execute in order to save one temporary Docker image * Added `php.ini` and `xdebug.ini` configurations * Updated the `composer install` command in order to run it without expecting user interaction and optimizing the autoloader class map * MySQL: * Modified the mapped directory to the `/docker-entrypoint-initdb.d` one from `$PWD/etc/infrastructure/mysql/data` to the currently available `./databases`. Why: This directory already contains all the databases and tables definitions. We just need to add the `CREATE DATABASE` and `USE` sentences in order to be fully compatible with the new standard way to initialize DB structures proposed by MySQL official image 🤟 * Added the `restaty: always` clause to the MySQL container in order to restard it when it fails * RabbitMQ: * Added the `rabbitmq` container in order to serve as a message broker server and be able to perform integration tests taking it into account * We've decided to go for the `rabbitmq:3.7-management` version in order to be able to have the RabbitMQ administration frontend available * Others: * Modified the `.env.dist` default values in order to maintain the same naming conventions suggested avobe while creating the DB, and use different values for each one of the variables in order to differentiate them

More info: CodelyTV#57

…nd check if the API is properly working

JavierCane

Thanks to all the people involved in this PR:

Firstly: Congrats @sdecandelario for the awesome work done! 🎉
Thanks also to @jorge07 for his great Docker best practices tips
Also thanks to @xserrat for his AWESOME MySQL tip (I didn't know it and I've used the approach suggested by you and @sdecandelario as you can see in this commit, it works like a charm!)
We'll continue working in this direction with the issue Optimize PHP Dockerfile with multistage builds (builder pattern) #61, so suggestions are much appreciated! 👼

Now, let's talk about the changes done:

We've done some changes here and there. I hope you don't mind jumping directly into your branch in order to perform these changes, but this way I can just continue the work where you left it without asking you to do further work 🙂

However, in order to let you know why we've done the committed changes, we've tried to isolate them into several commits with descriptive commit messages. Here you have the summary of the commit messages.

Please, let me know what do you think about the changes. We can discuss further modifications in other issues or PRs.

Thanks again for collaborating with this repo!

Modifications to the Docker Compose:

Docker Compose:
- Do not specify patch versions of the used images. Example: from nginx:1.15.5-alpine to nginx:1.15-alpine. Why: allow to upgrade automatically to a nugfix versions (we're using this repo as a example and we don't need to maintain a strict relation with a production environment)
- Change the ports mapping to a non standard ones in the host machine. Example: Nginx from port 80 to port 8030. Why: Avoid collisions with other containers or services exposed in these ports in the host machine. We have set the XX30 as the ending port for this project (don't ask why 🤷‍♂️)
- Renamed the container names. Example: from cqrs_codely_tv_nginx to codelytv-cqrs_ddd_php_example-nginx. Why: Follow a standard naming in order to avoid collisions and make it easier to find the needed container. Convention: %vendor%-%repository_or_project%-%docker_service%
- Changed the indentation in the docker-compose.yml from 4 to 2 spaces. Why: Follow the same convention as in the official Docker Compose website and community examples
- Modified the volume mapping $PWD by the shorter version of the current directory: .
Nginx:
- Renamed /etc/infrastructure/nginx/site.conf to default.conf. Why: Maintain the same standard name used by Nginx
PHP:
- Updated the PHP_IDE_CONFIG=serverName value to CodelyTvCqrsDddPhpExample in order to maintain the same naming conventions suggested avobe
- Dockerfile:
  - Removed the maintainer label since we're not publishing this image in any Docker Registry and it could be confusing for other collaborators to expect updates from an ocassional contributor to the repository
  - Added pdo and pdo_mysql extensions installation because we need them to run production code
  - Added xdebug installation because we need them to debug while developing
  - Unified all the commands to execute in order to save one temporary Docker image
  - Added php.ini and xdebug.ini configurations
  - Updated the composer install command in order to run it without expecting user interaction and optimizing the autoloader class map
MySQL:
- Modified the mapped directory to the /docker-entrypoint-initdb.d one from $PWD/etc/infrastructure/mysql/data to the currently available ./databases. Why: This directory already contains all the databases and tables definitions. We just need to add the CREATE DATABASE and USE sentences in order to be fully compatible with the new standard way to initialize DB structures proposed by MySQL official image 🤟
- Added the restaty: always clause to the MySQL container in order to restard it when it fails
RabbitMQ:
- Added the rabbitmq container in order to serve as a message broker server and be able to perform integration tests taking it into account
- We've decided to go for the rabbitmq:3.7-management version in order to be able to have the RabbitMQ administration frontend available
Others:
- Modified the .env.dist default values in order to maintain the same naming conventions suggested avobe while creating the DB, and use different values for each one of the variables in order to differentiate them

Minor changes

Remove unused SYMFONY_SECRET env var
Remove unused global/config/parameters.yml
Fix for "Required parameter $trustedHeaderSet missing" error. More info: Required parameter $trustedHeaderSet missing #57
Update README.md instructions on how to edit the local hosts file and check if the API is properly working

sdecandelario · 2018-10-31T09:38:11Z

Okey, perfect @JavierCane for merging and making some changes to the code, I will take a look and learn for further improvement for other cases, proud to can contribute to Codely :)

xserrat · 2018-11-05T09:32:09Z

Congrats @sdecandelario 👏 and awesome repo @JavierCane @rgomezcasas :)

sdecandelario added 17 commits October 7, 2017 19:19

Implemented the possibility to like a video

2ee026a

Implemented the creation of course

9f5f93f

Removed the id from the inside of command because we are passing in t…

fb16df1

…he constructor in video like creation

Added the infrastructure to run the application

6b7466f

Added the local ip of the docker container to the api_dev.php

a378fdb

Included some dependencies

3583f7e

Start implementing the like video

fef97be

Removed the docker compose

e8306e9

Merge remote-tracking branch 'upstream/master'

d5527de

Clean up the branch master

23d97bd

Merge remote-tracking branch 'upstream/master'

8b9c6ba

Merge remote-tracking branch 'upstream/master'

49a49c3

Merge remote-tracking branch 'upstream/master'

985ddd9

Merge

e951e84

Added docker-compose

f04d51e

Changed the variables of the .env.dist and edited the README

3925e8c

Added new blank line

2cbdff3

jorge07 reviewed Oct 8, 2018

View reviewed changes

sdecandelario added 5 commits October 9, 2018 19:28

Nginx make use of stderr and stdout

2f6f5e9

Symfony secret moved to the .env

587f8fd

Removed ssh port mapping

5f2e6aa

Removed the workdir from docker-compose and put into Dockerfile for p…

8b9f7ef

…hp service

Optimized the RUN commands, one for install linux packages an other t…

f28ffc4

…o configure php extensions

sdecandelario and others added 4 commits October 22, 2018 19:38

Added a volume to mysql to make a first data import

0c29165

Remove unused SYMFONY_SECRET env var

768d3a0

Remove unused parameters

141bf5b

JavierCane added 2 commits October 30, 2018 23:21

Fix for "Required parameter $trustedHeaderSet missing" error

6858b57

More info: CodelyTV#57

Update README.md instructions on how to edit the local hosts file a…

2998680

…nd check if the API is properly working

JavierCane self-requested a review October 30, 2018 22:55

JavierCane assigned JavierCane and sdecandelario Oct 30, 2018

JavierCane added Enhancement 😬 Reviewed Hacktoberfest labels Oct 30, 2018

JavierCane mentioned this pull request Oct 30, 2018

Optimize PHP Dockerfile with multistage builds (builder pattern) #61

Closed

JavierCane approved these changes Oct 30, 2018

View reviewed changes

JavierCane merged commit 022db00 into CodelyTV:master Oct 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docker compose #56

Docker compose #56

sdecandelario commented Oct 8, 2018

jorge07 Oct 8, 2018

jorge07 Oct 8, 2018

jorge07 Oct 8, 2018

jorge07 Oct 8, 2018

jorge07 Oct 8, 2018

jorge07 Oct 8, 2018

sdecandelario Oct 9, 2018

JavierCane Oct 30, 2018 •

edited

Loading

xserrat commented Oct 14, 2018 •

edited

Loading

sdecandelario commented Oct 18, 2018

xserrat commented Oct 19, 2018

JavierCane left a comment

sdecandelario commented Oct 31, 2018

xserrat commented Nov 5, 2018

Docker compose #56

Docker compose #56

Conversation

sdecandelario commented Oct 8, 2018

jorge07 Oct 8, 2018

Choose a reason for hiding this comment

jorge07 Oct 8, 2018

Choose a reason for hiding this comment

jorge07 Oct 8, 2018

Choose a reason for hiding this comment

jorge07 Oct 8, 2018

Choose a reason for hiding this comment

jorge07 Oct 8, 2018

Choose a reason for hiding this comment

jorge07 Oct 8, 2018

Choose a reason for hiding this comment

sdecandelario Oct 9, 2018

Choose a reason for hiding this comment

JavierCane Oct 30, 2018 • edited Loading

Choose a reason for hiding this comment

xserrat commented Oct 14, 2018 • edited Loading

sdecandelario commented Oct 18, 2018

xserrat commented Oct 19, 2018

JavierCane left a comment

Choose a reason for hiding this comment

Modifications to the Docker Compose:

Minor changes

sdecandelario commented Oct 31, 2018

xserrat commented Nov 5, 2018

JavierCane Oct 30, 2018 •

edited

Loading

xserrat commented Oct 14, 2018 •

edited

Loading