Share URL parameter displayName not being honored #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Share URL parameter
displayName
not being honoredType
Bug
Description
When a share URL is generated with
displayName=1
, it means that the username displayed should be Github's name and not the username. But when we copy the generated link in a new tab, even if thedisplayName=1
, we are still showing the username which is wrongSolution
On the share page, along with
size
andtheme
, I have addeddisplayName
as it was missing.In the URL generation, we are using
size
,theme
, anddisplayName
Use case validated
displayName=1
, we need to display the nameScreenshots
Issue
Fix