Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share URL parameter displayName not being honored #16

Merged
merged 2 commits into from
Dec 31, 2022
Merged

Share URL parameter displayName not being honored #16

merged 2 commits into from
Dec 31, 2022

Conversation

shrinathnayak07
Copy link
Contributor

Issue

Share URL parameter displayName not being honored

Type

Bug

Description

When a share URL is generated with displayName=1, it means that the username displayed should be Github's name and not the username. But when we copy the generated link in a new tab, even if the displayName=1, we are still showing the username which is wrong

Solution

On the share page, along with size and theme, I have added displayName as it was missing.
In the URL generation, we are using size, theme, and displayName

Use case validated

  1. By default, the username should be shown
  2. When the URL parameter has displayName=1, we need to display the name

Screenshots

Issue

Screenshot 2022-12-31 at 12 48 27 AM

Fix

Screenshot 2022-12-31 at 12 48 46 AM

Signed-off-by: Shrinath Nayak <shrinath.nayak@bazaarvoice.com>
@vercel
Copy link

vercel bot commented Dec 30, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @Codennnn on Vercel.

@Codennnn first needs to authorize it.

@shrinathnayak07 shrinathnayak07 changed the base branch from main to dev December 30, 2022 19:21
@shrinathnayak07 shrinathnayak07 changed the base branch from dev to main December 30, 2022 19:21
@Codennnn Codennnn merged commit 482d33b into Codennnn:main Dec 31, 2022
@Codennnn
Copy link
Owner

Thank you for fixing the bug and making GreenWall better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants