Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different interfaces for hist.rebin() and hist.group() #90

Closed
kpedro88 opened this issue May 29, 2019 · 2 comments · Fixed by #153
Closed

Different interfaces for hist.rebin() and hist.group() #90

kpedro88 opened this issue May 29, 2019 · 2 comments · Fixed by #153
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@kpedro88
Copy link
Contributor 

Signature: hfcat.rebin(old_axis, new_axis)

vs.

Signature: hfcat.group(new_axis, old_axes, mapping, overflow='none')

Since these are conceptually similar operations, ideally the order of arguments would be the same (old_axis, new_axis, ...).
@nsmith-
Copy link
Member

nsmith- commented May 30, 2019

100% agree, I was trying to pay attention to things like this but missed it. I'll see how much code it breaks before implementing, although as we're in pre-v1.0 I could in principle change it.

@lgray lgray added enhancement New feature or request good first issue Good for newcomers labels Jun 10, 2019
@andrzejnovak
Copy link
Collaborator

If this is revisited, could we also have an alternative syntax, where the axis would be created implicitly by just specifying the new binning?

@andrzejnovak andrzejnovak mentioned this issue Jun 28, 2019
Closed
nsmith- added a commit that referenced this issue Jul 28, 2019
@nsmith-
Change Hist.group() signature to be consistent with Hist.rebin()
4831f86 
Fixes #90
lgray pushed a commit that referenced this issue Jul 29, 2019
@nsmith- @lgray
Change Hist.group() signature to be consistent with Hist.rebin()
3d0db3a 
Fixes #90
@lgray lgray mentioned this issue Jul 29, 2019
Merged
@areinsvo areinsvo mentioned this issue Aug 5, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve hist interface CoffeaTeam/coffea
4 participants
@lgray @kpedro88 @nsmith- @andrzejnovak