Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "fix: updates from review" #1133

Merged
merged 4 commits into from
Jul 19, 2024
Merged

fix: Revert "fix: updates from review" #1133

merged 4 commits into from
Jul 19, 2024

Conversation

Saransh-cpp
Copy link
Contributor

Reverts #1130

Saransh-cpp
Saransh-cpp commented Jul 19, 2024
View reviewed changes
Copy link
Contributor Author

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add back useful changes

src/coffea/nanoevents/methods/candidate.py Outdated Show resolved Hide resolved
src/coffea/nanoevents/methods/delphes.py Outdated Show resolved Hide resolved
src/coffea/nanoevents/methods/delphes.py Outdated Show resolved Hide resolved
src/coffea/nanoevents/methods/delphes.py Outdated Show resolved Hide resolved
src/coffea/nanoevents/methods/delphes.py Outdated Show resolved Hide resolved
src/coffea/nanoevents/methods/physlite.py Outdated Show resolved Hide resolved
src/coffea/nanoevents/methods/physlite.py Outdated Show resolved Hide resolved
src/coffea/nanoevents/methods/physlite.py Outdated Show resolved Hide resolved
tests/test_nanoevents_vector.py Outdated Show resolved Hide resolved
tests/test_nanoevents_vector.py Outdated Show resolved Hide resolved
Saransh-cpp and others added 2 commits July 19, 2024 11:44
@Saransh-cpp
Add back useful changes
dc80e61 
* More tests

* Don't modify the global awkward behavior
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
8349641 
for more information, see https://pre-commit.ci
Saransh-cpp
Saransh-cpp commented Jul 19, 2024
View reviewed changes
tests/test_nanoevents_vector.py Outdated Show resolved Hide resolved
tests/test_nanoevents_vector.py Outdated Show resolved Hide resolved
@Saransh-cpp Saransh-cpp changed the title Revert "fix: updates from review" fix: Revert "fix: updates from review" Jul 19, 2024
@lgray
Copy link
Collaborator

lgray commented Jul 19, 2024

@Saransh-cpp this one is ready?

@Saransh-cpp
Copy link
Contributor Author

Yes!

@lgray lgray merged commit 54cc334 into CoffeaTeam:use_scikithep_vector Jul 19, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saransh-cpp @lgray