Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve parameters in paths #65

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Preserve parameters in paths #65

merged 4 commits into from
Sep 3, 2024

Conversation

nsmith-
Copy link
Member

@nsmith- nsmith- commented Aug 6, 2024

Fixes #64

@nsmith- nsmith- requested a review from lgray August 6, 2024 03:15
@lgray
Copy link
Contributor

lgray commented Sep 3, 2024

Can you please provide an example the symptom in #64 being ameliorated?

@nsmith-
Copy link
Member Author

nsmith- commented Sep 3, 2024

Test added

@lgray
Copy link
Contributor

lgray commented Sep 3, 2024

@nsmith- tests do not pass:
image

Please add python 3.12 to test matrix if possible?

@nsmith- nsmith- merged commit 6e36c03 into main Sep 3, 2024
8 checks passed
@nsmith- nsmith- deleted the params branch September 3, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paths drop parameters in unstrip_protocol
2 participants