Changes for Lavalink 3.4 release #103
Conversation
lavalink/node.py
Outdated
| headers = { | ||
| "Authorization": self.password, | ||
| "User-Id": str(self.user_id), | ||
| "Num-Shards": str(self.num_shards), | ||
| "Client-Name": str(self._client_name), |
There was a problem hiding this comment.
This is an equivalent of a user agent, it should just contain the name and version of the library, see Freya's Lavalink library for an example:
https://github.com/freyacodes/Lavalink-Client/blob/8d9b660b2c87bb4e286409e1c6aabe36f81a53d8/src/main/java/lavalink/client/io/Lavalink.java#L111
Per IMPLEMENTATION.md, the recommended format seems to be NAME/VERSION:
| "Client-Name": str(self._client_name), | |
| "Client-Name": f"Red-Lavalink/{__version__}", |
This means that any other changes related to client name (self._client_name, client_name param) can be reverted.
lavalink/lavalink.py
Outdated
| extra = { | ||
| "message": raw_data.get("exception", {}).get( | ||
| "message", "Something went wrong when decoding the track." | ||
| ), | ||
| "cause": raw_data.get("exception", {}).get("cause", "Unhandled Exception"), | ||
| } |
There was a problem hiding this comment.
All of the keys are always present:
| extra = { | |
| "message": raw_data.get("exception", {}).get( | |
| "message", "Something went wrong when decoding the track." | |
| ), | |
| "cause": raw_data.get("exception", {}).get("cause", "Unhandled Exception"), | |
| } | |
| exception_data = raw_data["exception"] | |
| extra = { | |
| "message": exception_data["message"], | |
| "cause": exception_data["cause"], | |
| "severity": enums.ExceptionSeverity(exception_data["message"]), | |
| } |
There was a problem hiding this comment.
This would cause issues for users who haven't updated their server to a 3.4 jar as the exception key won't be there for them.
There was a problem hiding this comment.
That doesn't matter, users are expected to be running the version newer or equal to the version that is shipped with Red.
There was a problem hiding this comment.
Red-Lavalink is theoretically not locked to Red alone.
There was a problem hiding this comment.
True but 0.x.0 versions can be breaking and we've bumped minimal jar version in the past:
#71
|
I also think we could add |
After our testing yesterday and the inconsistencies of the |
This will be required to use any v3.4+ Lavalink.jar on our builds, starting with https://github.com/Cog-Creators/Lavalink-Jars/releases/tag/3.4.0_1275.