Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Trace Logger class and use is across RLL to reduce log spam. #119

Merged
merged 9 commits into from
Mar 18, 2022

Conversation

Drapersniper
Copy link
Contributor

@Drapersniper Drapersniper commented Mar 10, 2022

First

@Jackenmen Jackenmen added this to the 0.10.0 milestone Mar 17, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 17, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 17, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 17, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 17, 2022
@aikaterna aikaterna merged commit 9edeba1 into Cog-Creators:develop Mar 18, 2022
@Drapersniper Drapersniper deleted the trace_logging branch March 18, 2022 15:48
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 18, 2022
…og-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging
aikaterna pushed a commit that referenced this pull request Mar 18, 2022
* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 18, 2022
…og-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 18, 2022
* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 18, 2022
…og-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 18, 2022
* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 18, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 18, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 18, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 20, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 21, 2022
* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 21, 2022
* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 21, 2022
* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 21, 2022
* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 28, 2022
* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 28, 2022
* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 29, 2022
* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 29, 2022
* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (Cog-Creators#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup
Jackenmen added a commit that referenced this pull request Mar 29, 2022
* WIP discord.VoiceProtocol

* make similar of old socket_response behavior.

* No longer pass voice_ws_func to node

* Cleanup.

* Fix tests.

* More cleanup

* More cleanup

* Fix style.

* hm yeah

* Remove node.get_voice_ws, and replace it with client.is_closed.

* Use Shard.is_closed instead of bot.is_closed.

* Include methods from HTTPClient in Player.

* ... forgot one.

* Put back RESTClient to Player instead of Node.
It needed Player.state to works properly.

* Delete node._remove_player. Use player.disconnect force instead.

* Add discord.py 2.0 changes

* Fix unwanted voice events being passed

* Fix 2/3 tests.

* Reformat.

* Assert from player.

* Simplify this.

* Improve get_channel logic (#112)

* Improve get_channel logic

* Update fixtures

* Style changes

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>

* Fix and complete the secure connection implementation (#116)

* Fix the partial implementation of a secure connection.

* https 1

* address review

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>

* Add Exception classes to RLL (#115)

* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup

* Major rework of shutdown and reconnect logs to avoid zombie tasks and… (#6)

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>

* conflict resolution with predas

* welp

* Conflict resolution between Develop and PredaaA/Feature/dpy-voiceprotocol

* Add Exception classes to RLL (#115)

* Add RLL Specific errors and use them where appropriate

* update exception name to remove "exception" and keep naming consistent with others

* Add a Trace Logger class and use is across RLL to reduce log spam. (#119)

* Add a Trace Logger class and use is across RLL to reduce log spam.

* formatting

* Tweaks

* fix wrong typehint

* change from debug to verbose

* update logs to not dump handled traceback on console

* add some logging around `lavalink.close()`

* add missing callback to tasks

* reorder for better logging

* Add RLL Specific errors and use them where appropriate

* conflict resolution + cleanup

* refix the conflict resolution

* Update lavalink.py

* address jack's review

* typing, docs, style

* address code review

* type the event handler (dispatch)

* Update lavalink/player.py

Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>

* missed this?

* Update lavalink.py

Co-authored-by: PredaaA <46051820+PredaaA@users.noreply.github.com>
Co-authored-by: aikaterna <20862007+aikaterna@users.noreply.github.com>
Co-authored-by: jack1142 <6032823+jack1142@users.noreply.github.com>
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 29, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 29, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Mar 30, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 3, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 3, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 3, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 3, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 3, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 3, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 4, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 4, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 4, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 4, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 4, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 4, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 4, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 5, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 6, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 6, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 6, 2022
Drapersniper added a commit to Drapersniper/Red-Lavalink that referenced this pull request Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants