Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a minimum model version #111

Open
danieldeutsch opened this issue Aug 19, 2018 · 2 comments
Open

Add a minimum model version #111

danieldeutsch opened this issue Aug 19, 2018 · 2 comments

Comments

@danieldeutsch
Copy link
Collaborator

The local pipeline hello world code was failing with the error

AttributeError: type object 'edu.illinois.cs.cogcomp.annotation.BasicTextAnnota' has no attribute 'createTextAnnotationFromListofListofTokens'

It turns out it was because the models I had in ~/.ccg_nlpy were outdated and the createTextAnnotationFromListofListofTokens method did not exist in the jar files that I had. After I redownloaded the models, the code ran successfully.

We should add a minimum required model version and check at runtime whether or not the available models are valid. If not, throw an error with instructions to download the new models.

This might have solved #106

@danyaljj
Copy link
Member

Yeah, that's a good point.

If no one is doing this, I can give it a try.

@nitishgupta
Copy link
Member

@danyaljj: We can do this during the object creation for the LocalPipeline class. Ideally, there should be a static field in the download.py file that has the least-supported version that LocalPipeline checks from. Also, if you're looking at this, could you add a version-number flag to download.py with possibly a least-supported flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants