Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use absolute path for RELATIVE_BASE_DIR #37

Merged
merged 1 commit into from
May 6, 2020

Conversation

furushchev
Copy link
Contributor

Fixes #36

By this PR, the first include directory for compiling .proto file is given as absolute path instead of relative path.

@BillWSY
Copy link
Member

BillWSY commented May 6, 2020

Thanks for the PR. Did you have a chance to test if the original example still works? If the examples in https://github.com/CogRob/catkin_grpc_examples still work, I am more than happy to accept this PR.

Again, thanks for your contribution.

@furushchev
Copy link
Contributor Author

@BillWSY Thanks for the comment!
I tried greeter_cc_server / greeter_cc_client and greeter_py_server / greeter_py_client in catkin_grpc_examples/greeter project.
Even with/without the change of this PR, it occurs errors on running greeter_py_server and greeter_py_client:

$ rosrun greeter greeter_py_server 
Traceback (most recent call last):
  File "/home/furushchev/catkin_ws/src/catkin_grpc_examples/greeter/scripts/greeter_py_server", line 3, in <module>
    from greeter import greeter_py_server
  File "/home/furushchev/catkin_ws/src/catkin_grpc_examples/greeter/src/greeter/greeter_py_server.py", line 15, in <module>
    class Greeter(hello_pb2.GreeterServicer):
AttributeError: 'module' object has no attribute 'GreeterServicer'

After I fixed the import path (created another PR), it works with/without this PR.

@BillWSY BillWSY merged commit 254b59b into CogRob:master May 6, 2020
@BillWSY
Copy link
Member

BillWSY commented May 6, 2020

Thank you so much! Apparently many things have changed since I originally made this script. I will merge the PR for now, but I will come back later to update it a bit to keep it up with the upstream.

@furushchev
Copy link
Contributor Author

@BillWSY Thanks for merging! It'd be better if the change is released. Thank you!

@furushchev furushchev deleted the abspath branch May 6, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

protoc fails if SRC_BASE is specified and proto files are given as absolute paths
2 participants