Skip to content
This repository has been archived by the owner on Feb 25, 2023. It is now read-only.

Refactor/architecture redesign es lint #81

Merged
merged 20 commits into from
Jun 8, 2021

Conversation

james-hummingbot
Copy link
Contributor

@james-hummingbot james-hummingbot commented Jun 3, 2021

  • add prettier
  • add more eslint rules
  • run lint check on precommit
  • clean up code as required by new rules

This also deletes unused code in src/static/uniswap-v3/helper_functions.js

@james-hummingbot james-hummingbot linked an issue Jun 3, 2021 that may be closed by this pull request
.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
.prettierignore Outdated Show resolved Hide resolved
.prettierrc Outdated Show resolved Hide resolved
Copy link
Contributor

@evseevnn evseevnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint and prettier configs looks good to me.

@james-hummingbot james-hummingbot marked this pull request as ready for review June 6, 2021 12:45
@dennisocana
Copy link
Contributor

For testing by @CoinAlpha/qa-team

@RC-13
Copy link

RC-13 commented Jun 7, 2021

@james-hummingbot We can't seem to interact with any of the endpoints, currently blocked and getting connection refused, same behavior when checking from Hummingbot client. Are we missing something here? Cross-checked on the development branch and was able to interact with the endpoints using postman and Hummingbot client.
image

@rxlxrxsx
Copy link

rxlxrxsx commented Jun 7, 2021

Running gateway without errors however the connection seems to be not established in the client

Screen Shot 2021-06-07 at 2 33 43 PM

Tried to check in the client if I'll be able to run an amm_arb strategy or check the balance but failed

Screen Shot 2021-06-07 at 4 03 18 PM

Screen Shot 2021-06-07 at 4 30 44 PM

@james-hummingbot
Copy link
Contributor Author

@rxlxrxsx @RC-13
Thanks, I will investigate further.

@james-hummingbot
Copy link
Contributor Author

@CoinAlpha/qa-team I have fixed some of the issues you have mentioned. Now I have it working with postman locally. Could you check again?

@RC-13
Copy link

RC-13 commented Jun 8, 2021

Confirming the reported issue has been fixed.

Copy link

@rxlxrxsx rxlxrxsx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed working by QA.

@dennisocana dennisocana merged commit eecf4a4 into development Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ESLint
8 participants