-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coding minor update #16
Conversation
Remarks: But this is up to your decision. |
LGTM |
I found that the subtitle translation is having some problems.. https://www.youtube.com/watch?v=M2cckDmNLMI Choose Japanese subtitle and translate to English. 0:23 is still okay, although the end of the sentence should not end with "it's" 0:30 the translation get broken. 0:33 completely no translation... |
@cyfung1031 I found that the offical timed texts are broken, any good ideas? I'm afraid it's hard to fix by this proj. |
I found that in https://greasyfork.org/en/scripts/456108, it uses Google's translation api which is quite good.
It can translate a very long text as well. In that Userscript, he translate the entire description content at once.
I guess you can modify this script like this. get the ask Google's translation api to help |
@CoinkWang see PR #18 |
some coding improvement is made without any affect to the function or features provided in this script.