Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JADX Mapping invalid #515

Closed
AdminHcat opened this issue Mar 31, 2022 · 6 comments
Closed

JADX Mapping invalid #515

AdminHcat opened this issue Mar 31, 2022 · 6 comments
Labels
3rd party problem A bug/problem but caused by a library

Comments

@AdminHcat
Copy link

AdminHcat commented Mar 31, 2022

Describe the bug

A clear and concise description of what the bug is.

To Reproduce

Steps to reproduce the behavior:

  1. Click Mapping - JADX
  2. *.jadx cannot be selected from the file selector
  3. Rename .jadx to .txt, try loading
  4. Nothing happened
@Col-E
Copy link
Owner

Col-E commented Mar 31, 2022

*.jadx cannot be selected from the file selector
Nothing happened

This is because .jadx is the project file. Its not the JadX mappings file. You need to use the generated *.jobf file instead. Which, I should also add as a supported extension.

@Col-E Col-E added the usage Not a bug, but a question/problem regarding usage label Mar 31, 2022
@AdminHcat
Copy link
Author

AdminHcat commented Apr 1, 2022

*.jadx cannot be selected from the file selector
Nothing happened

This is because .jadx is the project file. Its not the JadX mappings file. You need to use the generated *.jobf file instead. Which, I should also add as a supported extension.

i try there are some error
image
image
1.15p8.zip

@Col-E Col-E added bug and removed usage Not a bug, but a question/problem regarding usage labels Apr 1, 2022
@Col-E
Copy link
Owner

Col-E commented Apr 1, 2022

With the new map file provided, that looks like a bug. I'll take a look at it later today.

@AdminHcat
Copy link
Author

With the new map file provided, that looks like a bug. I'll take a look at it later today.

https://github.com/Col-E/Recaf/files/8396721/1.15p8.zip
OK, it's up there

And if lib is not loaded and mapping is loaded, an NPE will be thrown

@Col-E
Copy link
Owner

Col-E commented Apr 2, 2022

Oh wait a second, the format says thats a field but it has a method descriptor. Something is wrong with their output. That line should start with m.

@Col-E
Copy link
Owner

Col-E commented Apr 2, 2022

I opened a PR on JADX: skylot/jadx#1433

When that gets merged it should generate the correct mapping file output.
Or use an older version where the bug in JADX is not present. 1.3.2 and older should be safe to use since the problem was introduced here: skylot/jadx@0c9e322

@Col-E Col-E closed this as completed Apr 2, 2022
@Col-E Col-E added 3rd party problem A bug/problem but caused by a library and removed bug labels Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party problem A bug/problem but caused by a library
Projects
None yet
Development

No branches or pull requests

2 participants