Handle case where two paths resolve to the same class

[Col-E]

This can occur in jars that have version-specific implementations.

Consider multi-release jars:

src/
    main/
        java/
            com/
                baeldung/
                    multireleaseapp/
                        App.java
                        DateHelper.java
        java9/
            com/
                baeldung/
                    multireleaseapp/
                        DateHelper.java

Both DateHelper classes will need to be available to the user. The problem is the current workspace setup is based on a 1-to-1 relation of .class files to actual resource classes. So depending on the ZIP entry iteration order, only one will be chosen.

Some ideas for addressing this:

• Attach a Collection<ClassInfo> to resource class entries, which also get updated when the base is updated.

  • Consider mappings as well.
  • Requires Support ZIP entry [Comment] and [Extra] metadata recaf-3x-issues#2 but also for tracking original path name
  • Seems like it could get complicated to track these things fast

• On load detect duplicates and let users choose which they want to keep

  • Will break multi-release jars

• Rework the resource entries so instead of ItemInfo it will have ItemFamily

  • The family is responsible for tracking file metadata like Support ZIP entry [Comment] and [Extra] metadata recaf-3x-issues#2
  • The family can hold multiple sub ItemInfo values, such as multi-versioned classes
  • Will require LOTS of refactoring across the entire code-base

Things to consider about any one fix:

• How much refactoring will it require?
• How much of a pain in the ass will it be to use the "fix" as the new standard going forward?
• Does it make it easy for the user to undeerstand what happened, and how to get to the data they want?
• How does this work for intended Java usage, such as multi-release jars?
• How does this work for obfuscated usage, such as intentional zip file shenanigans and tricky JVM ZIP edge case handling?

[Col-E]

Addressed by 4x's new workspace model.

[Col-E]

How much refactoring will it require?

The answer is: "An entire rewrite"