Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using asset-packagist for npm assets #12

Merged
merged 1 commit into from May 19, 2020
Merged

Using asset-packagist for npm assets #12

merged 1 commit into from May 19, 2020

Conversation

ghost
Copy link

@ghost ghost commented May 19, 2020

No description provided.

@jdalsem jdalsem merged commit cd48d79 into ColdTrick:master May 19, 2020
@jdalsem
Copy link
Member

jdalsem commented May 19, 2020

Thanks... there is something wrong with your indentation (you mixed tabs and spaces). I merged anyway...

@jdalsem
Copy link
Member

jdalsem commented May 19, 2020

there was also an error in your composer.json
you can check this by running composer validate

you also needed to update the lock file after touching the composer.json. That can be done by running
composer update --lock

@jdalsem
Copy link
Member

jdalsem commented May 19, 2020

i already did the above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants