Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass argument session down to watch() #18

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ilyaZar
Copy link
Contributor

@ilyaZar ilyaZar commented Jul 4, 2023

Fix #17

Could not to get reprexes working with these shiny reactive console things...

so here is the output from my console copy pasted:

library(shiny)
library(gargoyle)
 
shiny::reactiveConsole(TRUE)
s <- shiny::MockShinySession$new()
 
init("pif", session = s)
#> [[1]]
#> reactiveVal: [1] "0" 

test_for_on_function <- on(
     "pif",
     {
         cat("TEST fails")
     },
     session = s
)
test_for_on_function$.func()
#> TEST fails
shiny::reactiveConsole(FALSE)

The message "TEST fails" prints correctly compared to the issue where the error is produced.

ilyaZar added a commit to ilyaZar/gargoyle that referenced this pull request Jul 6, 2023
- adding the session argument in view of ColinFay#17 and ColinFay#18
- remove redundant whitespace
@ilyaZar ilyaZar mentioned this pull request Feb 19, 2024
@ColinFay
Copy link
Owner

Sorry for being late on this.

Thanks for the PR

@ColinFay ColinFay merged commit ed259b0 into ColinFay:master Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: arg session not passed down from on() to watch()
2 participants