handle large sectors_per_cluster (closes #12) #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leofidus
force-pushed
the
large_cluster_size
branch
from
520bf15
to
b000503
Compare
|
Added some error handling, which is probably the controversial part of this. You could as easily argue that |
ColinFinck
added a commit
that referenced
this pull request
Mar 13, 2022
A cluster size of 2 MiB is the maximum currently supported by Windows. See https://dfir.ru/2019/04/23/ntfs-large-clusters/ for more details. Fixes #12 Thanks to @leofidus for the initial implementation in #13! Co-authored-by: Jannis Froese <jannis.froese@deepsign.de>
|
Thanks for the report and the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows Wikipedia's description "If the value is greater than 0x80, the amount of sectors is 2 to the power of the absolute value of considering this field to be negative."
Annoyingly sectors_per_cluster can't just be an i8 with different behavior depending on the sign because that breaks for 128 (so a cluster size of 64k).