Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› οΈ fonts λ™μž‘ 였λ₯˜ κ°œμ„  #29

Merged
merged 3 commits into from
May 4, 2024

Conversation

BangDori
Copy link
Collaborator

@BangDori BangDori commented May 3, 2024

μž‘μ—… 이유

#18 이슈 처리


μž‘μ—… 사항

  • font-weight이 μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ„λ‘
  • letter-spacing이 μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λ„λ‘
  • font sizeκ°€ κΈ°κΈ° μ‚¬μ΄μ¦ˆμ— 따라 λ³€λ™λ˜λ„λ‘

리뷰어가 μ€‘μ μ μœΌλ‘œ 확인해야 ν•˜λŠ” λΆ€λΆ„

  • bold, semibold λ“±μ˜ ν‚€μ›Œλ“œκ°€ μ μ ˆν•œ 값에 λŒ€μ‘λ˜μ—ˆλ‚˜μš”? (MDN Common Weight)

λ°œκ²¬ν•œ 이슈

ν˜„μž¬ λΈŒλΌμš°μ €μ—μ„œ 폰트λ₯Ό 확인해보면 λ‹€μŒκ³Ό 같이 μŠ€νƒ€μΌ μ‹œνŠΈκ°€ μ μš©λ˜μ–΄ μžˆλŠ” 것을 확인할 수 μžˆμŠ΅λ‹ˆλ‹€.

image

제 μƒκ°μœΌλ‘œλŠ” μ•„λ§ˆ ν•΄λ‹Ή ν”Όλ“œ 메인 νŽ˜μ΄μ§€λ₯Ό λ Œλ”λ§ν•˜κΈ° μœ„ν•΄ μ‚¬μš©λ˜λŠ” μŠ€νƒ€μΌ μ‹œνŠΈλ“€μ—μ„œ @use λ₯Ό 톡해 _index.scssλ₯Ό κ°€μ Έμ™€μ„œ λ°œμƒν•œ 문제라고 μƒκ°ν•©λ‹ˆλ‹€. κ·Έλž˜μ„œ 이 μ΄μŠˆμ— λŒ€ν•΄μ„œλŠ” #18 에 ν•  일 λͺ©λ‘μ— μΆ”κ°€ν•˜κ³ , #27 λ₯Ό λ³‘ν•©ν•œ 이후에 μ§„ν–‰ν•˜λ„λ‘ ν•˜κ² μŠ΅λ‹ˆλ‹€.

@BangDori BangDori self-assigned this May 3, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-29.d37mn03xh3qyyz.amplifyapp.com

@Legitgoons Legitgoons self-requested a review May 3, 2024 19:14
Copy link
Member

@Legitgoons Legitgoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€. λ³‘ν•©ν•˜μ…”λ„ μ’‹μŠ΅λ‹ˆλ‹€!

@BangDori BangDori merged commit 7d93c31 into main May 4, 2024
2 checks passed
@BangDori BangDori deleted the fix/issue-18-fonts branch May 4, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants