Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Profile User Api #79

Merged
merged 26 commits into from
May 29, 2024
Merged

✨ Profile User Api #79

merged 26 commits into from
May 29, 2024

Conversation

Legitgoons
Copy link
Member

@Legitgoons Legitgoons commented May 24, 2024

작업 이유

  • Profile에서 User 정보 출력

작업 사항

1️⃣ useGetUser Hook 구현

2️⃣ Profile 경로 설정

  • 아직 userPK값을 가져올 token이 없기에, 임시로 userId의 값에 따라 다르게 출력되도록 구현했습니다.
    • userId의 값이 1이라면 내 프로필
    • 1이 아니라면, 다른 사람의 프로필
  • 각 유저에 알맞게 정보를 출력하기 위해 다음 부분들을 수정했습니다.
    • routers/index.tsx 수정
    • shared/ui/profile/Profile.tsx에 userId와 isLink를 props으로 추가
      linkedUserId?: number;
    • widgets/feed-main-list/ui/Feed.tsx와 widgets/profile-feed-list/ui/ProfileFeedList.tsx 내부의 Profile 컴포넌트에 user.id와 isLink를 props로 주도록 설정

3️⃣ ProfileMainPage 수정 설정

  • ProfileFeedList를 임시로 삭제하였습니다. 추후 API 개발이 완료된 이후, 다시 추가할 예정입니다.

리뷰어가 중점적으로 확인해야 하는 부분

  • 각 유저에 알맞게 정보가 출력되고 있는지
  • react-query를 사용한 api 호출 코드가 적절한지
  • Feed 컴포넌트가 수정된 것을 인지했는지
  • 아래의 이슈를 인지했는지

발견한 이슈

  1. 🐛 Params URL에 Icon Sprite 미 적용 버그 #75 이슈가 users/:userId에서도 동일하게 발생하고 있습니다.
  • 임시로 svg파일을 ProfileUser 컴포넌트에서 사용하도록 구현했습니다.
  1. 🐛 Profile 페이지 스크롤 버그 #81

@Legitgoons Legitgoons self-assigned this May 24, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-79.d37mn03xh3qyyz.amplifyapp.com

Copy link
Collaborator

@BangDori BangDori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프로필 하단에 사용자의 게시물은 다음 PR에서 진행하시는 건가용?

src/pages/profile/ui/ProfileMainPage.tsx Outdated Show resolved Hide resolved
src/shared/ui/profile/Profile.tsx Outdated Show resolved Hide resolved
src/widgets/profile-user/api/useGetUser.ts Outdated Show resolved Hide resolved
src/widgets/profile-user/assets/profile-change-icon.svg Outdated Show resolved Hide resolved
src/widgets/profile-user/ui/ProfileUser.tsx Show resolved Hide resolved
src/widgets/profile-user/ui/ProfileUser.tsx Show resolved Hide resolved
src/widgets/profile-user/ui/ProfileUser.tsx Show resolved Hide resolved
Copy link
Collaborator

@BangDori BangDori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니당~

@Legitgoons Legitgoons merged commit e5b3403 into main May 29, 2024
2 checks passed
@Legitgoons Legitgoons deleted the feature/PW-346-profile-api branch May 29, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants