Fix for AnsiString #279
Closed
Fix for AnsiString #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If SqlDbType is not set on the param, the param still gets passed as nvarchar MS Sql Server (2012 11.0.6020) PetaPoco 5.1.153
Set SqlDbType of AnsiString Param
|
HI @Styn Thanks for the contribute. Are you able to re-issue this PR for the development branch, as changes go through development and then to master? Also, can you add or at least list how this can be tested? Thanks, Wade |
|
@Styn, sorry I think I referenced the wrong person in my previous comment. Can you please reissue to the development branch? |
|
Also, can you please add an integration test or tell me how you'd go about testing this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using AnsiString, the param is still passed as a nvarchar.
Setting the SqlDbType fixes this issue
This is when using PetaPoco 5.1.153 and MS Sql Server 2012 (11.0.6020)